After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756058 - Extending selection with different font doesn't work
Extending selection with different font doesn't work
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-04 19:51 UTC by Egmont Koblinger
Modified: 2018-11-07 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Egmont Koblinger 2015-10-04 19:51:24 UTC
Select some parts with the mouse. Change the font size. Extend the selection with Shift+click -> buggy.

This is because selection_origin and selection_last contain mouse click coordinates in pixels. (The y coordinate is actually relative to the beginning of the history (similarly to insert_delta), but in pixels.)

A quick hackish solution could be to adjust them on font change.

A cleaner (?) solution could be to convert them to row/column numbers as floats, similarly to the new smooth scroll_delta.
Comment 1 Christian Persch 2015-10-04 20:17:03 UTC
Using grid coordinates sounds better to me. Not sure it needs to be float, since selection can only be entire cells.
Comment 2 Egmont Koblinger 2015-10-09 18:30:17 UTC
Not sure what and how we're using these values for; maybe we need to remember the values with half-cell granularity as per bug 755183 comment 2. Maybe not.
Comment 3 Egmont Koblinger 2018-09-01 18:25:21 UTC
Will probably get fixed as part of https://gitlab.gnome.org/GNOME/vte/issues/34.
Comment 4 Egmont Koblinger 2018-11-07 13:13:42 UTC
Fixed as part of https://gitlab.gnome.org/GNOME/vte/issues/34.