After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756033 - Don't leak internal RepositoryError on import
Don't leak internal RepositoryError on import
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-04 09:29 UTC by Christoph Reiter (lazka)
Modified: 2015-10-26 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't leak internal RepositoryError on import. (2.23 KB, patch)
2015-10-04 09:30 UTC, Christoph Reiter (lazka) 		committed Details | Review

Description Christoph Reiter (lazka) 2015-10-04 09:29:43 UTC 
...
Comment 1 Christoph Reiter (lazka) 2015-10-04 09:30:07 UTC 
Created attachment 312623 [details] [review]
Don't leak internal RepositoryError on import.

In case a dependency of the imported namespace has a version
conflict with an already loaded version, import would raise
RepositoryError.

This fixes it to raise an ImportError instead.
Comment 2 Simon Feltman 2015-10-25 19:14:02 UTC 
Review of attachment 312623 [details] [review]:

This seems fine, please commit with link to ticket.