After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755970 - app: Add a nicer label for polari homepage in about dialog
app: Add a nicer label for polari homepage in about dialog
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal enhancement
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-02 08:25 UTC by Bastian Ilsø
Modified: 2015-10-14 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
about dialog from evince (29.98 KB, image/png)
2015-10-02 08:25 UTC, Bastian Ilsø 		  Details
app: Use a custom label for the website link (908 bytes, patch)
2015-10-14 02:20 UTC, Florian Müllner 		committed Details | Review

Description Bastian Ilsø 2015-10-02 08:25:34 UTC 
Created attachment 312549 [details]
about dialog from evince

Commit 678d0fddda63ec39cdf617b5b0bbda457c0859a4 [0] added a link to Polari's website but it would be nice with a better website label, fx "Project homepage" or "Website" (see fx evince reference).


[0]: https://git.gnome.org/browse/polari/commit/?id=678d0fddda63ec39cdf617b5b0bbda457c0859a4
Comment 1 Florian Müllner 2015-10-02 09:12:55 UTC 
(In reply to Bastian Ilsø from comment #0)
> Commit 678d0fddda63ec39cdf [0] added a link to Polari's
> website but it would be nice with a better website label

I went with "Learn more about Polari" when I wrote the patch, but as we were already in string freeze, I only pushed the website one and kept the label patch locally ...
Comment 2 Bastian Ilsø 2015-10-02 09:15:21 UTC 
ah ok, feel free to resolve the bug then.
Comment 3 Florian Müllner 2015-10-02 09:17:29 UTC 
Well, we are still in string freeze :-)
Comment 4 Florian Müllner 2015-10-14 02:20:54 UTC 
Created attachment 313234 [details] [review]
app: Use a custom label for the website link

The default is a bit dull, use something more descriptive and nicer.

master is no longer frozen, so here's my suggestion ...
Comment 5 Bastian Ilsø 2015-10-14 15:40:37 UTC 
(In reply to Florian Müllner from comment #4)
> Created attachment 313234 [details] [review] [review]
> app: Use a custom label for the website link
> 
> The default is a bit dull, use something more descriptive and nicer.
> 
> master is no longer frozen, so here's my suggestion ...

Read, tested, LGTM.
Comment 6 Florian Müllner 2015-10-14 15:58:08 UTC 
Attachment 313234 [details] pushed as bf06f1b - app: Use a custom label for the website link