GNOME Bugzilla – Bug 755946
Provide e better way to highlight current day in the general view
Last modified: 2017-04-17 18:20:40 UTC
Hi, It would be great to have an option to shadow or color the current day to make it easier to find it with a glance. Although it is currently highlighted via the number of the day sometimes it gets difficult to find it when there are a lot of appointments shown. Thanks.
It should not be an option, it just needs to be highlighted better, at least by default when the calendar is opened. Currently my first thought when opening the calendar is "what day is today?"
It could use the same color blue that's currently used for date selections, for example. Or something similar to that.
Hi, How exactly it should be highlighted? or We could also add an option for the user to choose the color for highlighting. I would like to work on this bug. Can anyone tell me what exactly the enhancement should be?
Hi! Glad you're interested in this bug.... (In reply to Michael Catanzaro from comment #2) > It could use the same color blue that's currently used for date selections, > for example. I'd start with implementing this. If Georges wants a different color scheme, that should be easy to change once you've got it working with some color. (In reply to nj4710 from comment #3) > We could also add an option for the > user to choose the color for highlighting. It should not be configurable (we only want preferences for important things to keep the UI simple).
Hi, Do you want a color change like this https://cloud.githubusercontent.com/assets/13117482/17463563/f950195e-5ce5-11e6-910c-8a945c842f84.jpeg ? or the whole cell of current date should be highlighted? I have implemented this in both year and month views.I am unable to understand the requirement. Can you please help me because I am new to opensource contribution.
(In reply to nj4710 from comment #5) > or the whole cell of current date should be highlighted? ^ This, the whole cell should be highlighted to draw the user's attention to it right away!
Created attachment 332999 [details] better way to highlight current day in month view Hi, Can you please tell me if this looks fine or not? I have implemented this in month view. If there are any changes to be made please let me know.
A little bit more subtle, maybe. How about an opacity of 0.4? Also, it'd be better if you attach your patch so I can test here. If you're in doubt, don't worry - there's a special place for you: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow. Thanks for your time!
Created attachment 333029 [details] [review] In the commit we provide a better way to highlight the current date.
Review of attachment 333029 [details] [review]: Good work! Please, correct code as commented below, and I'll gladly accept your patch. The commit message needs improvements. GNOME Calendar uses a pattern, you can check [1] Still in the commit message, the body is empty. The Newcomers page has some guidelines on how they should be written [2]. [1] https://git.gnome.org/browse/gnome-calendar/log/?h=wip/gbsneto/timezone-marks [2] https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines ::: data/theme/gtk-styles.css @@ +31,2 @@ calendar-view.current { + background-color: alpha(@theme_selected_bg_color,0.45); Put a space after the comma.
Created attachment 333060 [details] [review] month-view: highlight the whole cell of current day In this commit, we changed the background area of current day. Presently, the current day is highlighted by the number. This makes difficult for the user to identify it when there are lot of events. To fix this, we changed the color of background and made background area equal to the cell's area.
Review of attachment 333060 [details] [review]: Seems like this patch is applied ~after~ the previous one. You should merge this patche and the former into a single patch (use git rebase to do that). Otherwise, the commit message is very good now.
Created attachment 333115 [details] [review] month-view: highlight the whole cell of current day In this commit, we changed the background area of current day. Presently, the current day is highlighted by the number. This makes difficult for the user to identify it when there are lot of events. To fix this, we changed the color of background and made background area equal to the cell's area.
Review of attachment 333115 [details] [review]: Some more fixes are needed. ::: data/theme/gtk-styles.css @@ +31,3 @@ calendar-view.current { + background-color: alpha(@theme_selected_bg_color, 0.45); + border-radius: 0px; Remove the 'border-radius' line ::: src/gcal-month-view.c @@ +1764,3 @@ gtk_render_background (context, cr, + cell_width * (column - priv->k), + cell_height * (row + 1 + first_row_gap) - start_grid_y / 2 - padding.bottom, This 'y' calculation doesn't work here. I changed to: cell_height * (row + first_row_gap) + start_grid_y and it worked.
Created attachment 333180 [details] [review] month-view: highlight the whole cell of current day In this commit, we changed the background area of current day. Presently, the current day is highlighted by the number. This makes difficult for the user to identify it when there are lot of events. To fix this, we changed the color of background and made background area equal to the cell's area.
Can someone please tell me the status of this bug?
Thanks for working on this bug. The patch looks great, and it's been published on master with a minor adjustment on the alpha value. Congratulations for your first patch! And sorry for the delay on the response. Attachment 333180 [details] pushed as 27ca660 - month-view: highlight the whole cell of current day