After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755941 - GtkCalendar sometimes emits "day-selected" twice
GtkCalendar sometimes emits "day-selected" twice
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-10-01 13:46 UTC by Lars Karlitski
Modified: 2018-05-02 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
calendar: always emit "day-selected" once (6.14 KB, patch)
2015-10-01 13:46 UTC, Lars Karlitski
none Details | Review

Description Lars Karlitski 2015-10-01 13:46:23 UTC
GtkCalendar emits "day-selected" twice when selecting a day from the previous
or next month. This is wasteful and makes GtkCalendar look inconsistent after
the first signal emission (new day but old month).
Comment 1 Lars Karlitski 2015-10-01 13:46:27 UTC
Created attachment 312479 [details] [review]
calendar: always emit "day-selected" once

"day-selected" was emitted twice when clicking on a day of the previous
or next month. This was because calendar_set_month{next,prev}() always
selected the first (or last) day of the newly focussed month. Callers
that wanted a different day to be selected had to do so after calling
one of those functions.

Fix this by passing the desired day into those functions directly.
Comment 2 Matthias Clasen 2018-02-10 05:15:32 UTC
We're moving to gitlab! As part of this move, we are moving bugs to NEEDINFO if they haven't seen activity in more than a year. If this issue is still important to you and still relevant with GTK+ 3.22 or master, please reopen it and we will migrate it to gitlab.
Comment 3 Matthias Clasen 2018-04-15 00:06:33 UTC
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new
Comment 4 Iain Lane 2018-04-16 18:14:51 UTC
Sorry for the delay in checking. I think I got in on time.

This is still relevant, I think.
Comment 5 GNOME Infrastructure Team 2018-05-02 16:46:28 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gtk/issues/576.