After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755935 - [review] add ".config.enable" setting to disable configuration snippets [th/config-enable-bgo755935]
[review] add ".config.enable" setting to disable configuration snippets [th/c...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-10-01 12:10 UTC by Thomas Haller
Modified: 2015-10-05 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2015-10-01 12:10:05 UTC 
Please review
Comment 1 Dan Williams 2015-10-02 22:11:15 UTC 
Is this for testing?  Or what's the use-case to disable snippets?
Comment 2 Dan Williams 2015-10-02 22:13:19 UTC 
Ok, nevermind, I read the patch description and it sounds OK to me, as long as the enable/disable remains isolated to the snippet itself (which is what's implemented, so good :).  Haven't reviewed the code yet though...
Comment 3 Thomas Haller 2015-10-03 11:25:58 UTC 
Added "env:" predicate, and improved the way to match version numbers.

Repushd.
Comment 4 Beniamino Galvani 2015-10-05 12:05:59 UTC 
Pushed a couple of fixups. Some of the changes to NM.conf.xml.in in
patch "config: drop global-dns.enable option ..." belong to the
previous patch. Otherwise looks good.
Comment 5 Thomas Haller 2015-10-05 13:58:16 UTC 
(In reply to Beniamino Galvani from comment #4)
> Pushed a couple of fixups. Some of the changes to NM.conf.xml.in in
> patch "config: drop global-dns.enable option ..." belong to the
> previous patch. Otherwise looks good.

Thanks. Fixed all and repushed.