After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755854 - validate:launcher: Add proper check for is_seekable
validate:launcher: Add proper check for is_seekable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other Linux
: Normal normal
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-30 07:48 UTC by Vineeth
Modified: 2016-02-17 21:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix return value of is_seekable function (1.20 KB, patch)
2015-09-30 07:49 UTC, Vineeth 		none Details | Review
fix return value of is_seekable function (1.26 KB, patch)
2015-10-01 00:13 UTC, Vineeth 		none Details | Review
fix return value of is_seekable function (1.20 KB, patch)
2015-10-05 03:02 UTC, Vineeth 		none Details | Review
fix return value of is_seekable function (1.14 KB, patch)
2015-11-12 00:05 UTC, Vineeth 		committed Details | Review

Description Vineeth 2015-09-30 07:48:17 UTC 
The seekable variable in media_info file is of type string. When checking if the file is seekable using is_seekable, it just returns the string, resulting in it always being true.
It should actually be comparing the string and returning true or false based on comparision
Comment 1 Vineeth 2015-09-30 07:49:31 UTC 
Created attachment 312399 [details] [review]
fix return value of is_seekable function
Comment 2 Vineeth 2015-10-01 00:13:39 UTC 
Created attachment 312456 [details] [review]
fix return value of is_seekable function
Comment 3 Thibault Saunier 2015-10-02 15:14:21 UTC 
Review of attachment 312456 [details] [review]:

::: validate/launcher/baseclasses.py
@@ +1678,2 @@
     def is_seekable(self):
+        if self.media_xml.attrib["seekable"] == "True" or \

Please do instead:

  self.media_xml.attrib["seekable"].lower()
Comment 4 Vineeth 2015-10-05 03:02:28 UTC 
Created attachment 312659 [details] [review]
fix return value of is_seekable function
Comment 5 Vineeth 2015-11-11 00:33:15 UTC 
ping :)
Comment 6 Thibault Saunier 2015-11-11 08:57:55 UTC 
Review of attachment 312659 [details] [review]:

::: validate/launcher/baseclasses.py
@@ +1681,2 @@
     def is_seekable(self):
+        if self.media_xml.attrib["seekable"].lower() == "true":

return self.media_xml.attrib["seekable"].lower() == "true"
Comment 7 Vineeth 2015-11-12 00:05:22 UTC 
Created attachment 315303 [details] [review]
fix return value of is_seekable function
Comment 8 Vineeth 2015-12-22 06:24:10 UTC 
ping :)
Comment 9 Vineeth 2016-02-17 07:01:24 UTC 
ping :)
Comment 10 Thibault Saunier 2016-02-17 21:37:10 UTC 
Thanks for that and sorry for the delay!