After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755832 - interpolationcontrolsource: memory corruption due to wrong assignment
interpolationcontrolsource: memory corruption due to wrong assignment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-30 03:34 UTC by Vineeth
Modified: 2015-10-02 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix wrong assignment (1.07 KB, patch)
2015-09-30 03:38 UTC, Vineeth 		rejected Details | Review

Description Vineeth 2015-09-30 03:34:34 UTC 
The following failure occurs in volume element

Running suite(s): volume
*** Error in `/home/vineethtm/gst/master/gst-plugins-base/tests/check/elements/.libs/lt-volume': free(): invalid next size (normal): 0x09057910 ***
0%: Checks: 1, Failures: 0, Errors: 1
elements/volume.c:1854:E:general:test_controller_defaults_at_ts0:0: (after this point) Received signal 6 (Aborted)


This is happening because of the change in function
interpolate_linear_get_value_array()

      *values++ = NAN;
The actual change should have been
      *values = NAN;
Comment 1 Vineeth 2015-09-30 03:38:26 UTC 
Created attachment 312390 [details] [review]
fix wrong assignment
Comment 2 Sebastian Dröge (slomo) 2015-10-02 13:03:20 UTC 
Comment on attachment 312390 [details] [review]
fix wrong assignment

This was fixed already:

commit 9a30399e4f508269d72cc8c1457f94beb363eb09
Author: Stefan Sauer <ensonic@users.sf.net>
Date:   Thu Oct 1 22:09:58 2015 +0200

    interpolationcontrolsource: fix write over the array size
    
    The '++' got incidentially added during the refactoring in
    2fe3939ce7ea84c45dd922e7f1097dd07f11fc5d.
Comment 3 Tim-Philipp Müller 2015-10-02 13:24:36 UTC 
Well, it would have been nice if Vineeth's patch which is identical had been pushed instead.