GNOME Bugzilla – Bug 755825
Incorrect icon used for new tab button
Last modified: 2016-01-10 15:16:30 UTC
Terminal 3.18 has a New Tab icon packed into the end of its GtkNotebook. This (along with the tab list) is really great; I wish those were in upstream GtkNotebook. Anyway, the bug is that a color icon when it should be a symbolic icon.
Created attachment 312387 [details] Screenshot of icon problem
Created attachment 312393 [details] [review] window: Use a symbolic new tab icon https://developer.gnome.org/hig/3.18/icons-and-artwork.html.en
Hmm. I didn't use a symbolic variant since I modelled this on how firefox's tab bar looks like.
If Firefox was a GNOME app, I would file a bug against it too. :) There are guidelines under the heading "Color vs. symbolic icons" in the link above.
Created attachment 312501 [details] Screenshot using corrected icon
*** Bug 756287 has been marked as a duplicate of this bug. ***
Hi, are you planning to accept this? Seems silly to add such a small fix to the list of shared patches that downstreams are starting to accumulate for gnome-terminal....
Well, I guess I was waiting for an explanation of why it's a good idea to use a different icon for this than the most-used desktop app this is modelled on (firefox) :-)
Also, list-add-symbolic is barely visible since it's grey on slightly-lighter-grey of the notebook action area background…
(In reply to Christian Persch from comment #8) > Well, I guess I was waiting for an explanation of why it's a good idea to > use a different icon for this than the most-used desktop app this is > modelled on (firefox) :-) Because the GNOME HIG prohibit use of color icons with only a few exceptions, see comment #2. A new tab icon is not an exception. Firefox is not a GNOME app by any stretch of imagination, so I don't see how it's relevant at all. (In reply to Christian Persch from comment #9) > Also, list-add-symbolic is barely visible since it's grey on > slightly-lighter-grey of the notebook action area background… It's exactly the same color as the close buttons in the tabs. Probably we should not make those blue as well. :)
(In reply to Michael Catanzaro from comment #10) > (In reply to Christian Persch from comment #8) > > Well, I guess I was waiting for an explanation of why it's a good idea to > > use a different icon for this than the most-used desktop app this is > > modelled on (firefox) :-) > > Because the GNOME HIG prohibit use of color icons with only a few > exceptions, see comment #2. A new tab icon is not an exception. I was asking for a _reason_, not a citation by chapter and verse... Anyway, since I've changed this to new-tab-symbolic on master now, same as epiphany uses.