After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755793 - redesign content-changed signal
redesign content-changed signal
Status: RESOLVED OBSOLETE
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal critical
: ---
Assigned To: grilo-maint
grilo-maint
Depends on: 755181
Blocks:
 
 
Reported: 2015-09-29 14:36 UTC by Xavier Claessens
Modified: 2018-09-24 09:37 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Xavier Claessens 2015-09-29 14:36:17 UTC
See bug#755181 comment #13 for details
Comment 1 Bastien Nocera 2015-10-05 10:41:08 UTC
(In reply to Xavier Claessens from comment #0)
> See bug#755181 comment #13 for details

Can you try writing what the docs for the new signal would be? That would make it easier to review, and see whether it has corner cases.
Comment 2 Juan A. Suarez Romero 2015-10-07 11:03:39 UTC
Of course this requires more thought, but the main difference regarding the current signal is that it would add the "parent" folder.

So "content-changed" signal would be something like

void
user_function (GrlSource          *source,
               GrlMedia           *parent,
               GPtrArray          *changed_medias,
               GrlSourceChangeType change_type,
               gpointer user_data)


As seen, we removed the "location_unknown" and added a "parent" parameter.

A source emitting with "parent" but not "changed_medias" is notifying that something changed in the "parent" folder, but can't be more explicit about which medias changed.

The idea of the parent is that the client can either decide to re-browse (using parent), or use the changed_medias to update the list of medias.
Comment 3 GNOME Infrastructure Team 2018-09-24 09:37:06 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/70.