I would be willing to mentor anyone interested in fixing this.

(see mockup here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/maps/v2/osm-editing.png)

Hi Jonas,

I would love to help out on the issue. But, I am a complete beginner to GNOME (never touched codebase). Would that be ok?

(In reply to Anuj from comment #3)
> Hi Jonas,
> 

Hi Anuj!

> I would love to help out on the issue. But, I am a complete beginner to
> GNOME (never touched codebase). Would that be ok?

That sounds awesome! Let me know what kind of help you want!
You can ask here or on IRC at #gnome-maps (GIMPnet) or using our mailing list!
That is on maps-list@gnome.org!

Have you seen the Newcomers guide?
https://wiki.gnome.org/action/show/Newcomers

Welcome to Maps!

Created attachment 314442 [details] [review]
Using stars instead of hearts for favorite places

Screenshot:
Favorite image https://imgur.com/azTIA8x
Non-favorite image https://imgur.com/ypiqpxT

Review of attachment 314442 [details] [review]:

Thanks looks great!

Small small nitpick: Please use the present form in commit message.
So "Use stars instead..." and not "Used stars instead..."

I would like to hear designers view on this as well. So the button still get de-pressed, or toggled on click, but now we also switch between the non-starred and starred icon.

A question: Should the icon in the header-bar be non-starred when there are no favorite places?

::: src/mapBubble.js
@@ +116,3 @@
         button.active = isFavorite;
+
+        if(button.active)

Should be a space after if here.

Review of attachment 314442 [details] [review]:

Also I noticed there were som white-space damage as well, on line 122. I noticied this by going:

$ git diff HEAD~1 --check
src/mapBubble.js:122: trailing whitespace.

Get in to the habit of checking this on your own!
Thanks!

Created attachment 314452 [details] [review]
Using stars instead of hearts for favorite places

Review of attachment 314452 [details] [review]:

Thanks looks fine!

I'm on the road and don't have my machine with jhbuild with me right now, but I'll take a look during the weekend.