GNOME Bugzilla – Bug 755771
When joining a room, auto-choose the network from selected room (if any)
Last modified: 2015-10-07 20:44:58 UTC
I usually have something like this: irc.freenode.net foo bar irc.gnome.org [baz] "baz" is selected. When I click the + button to join a new room, it defaults to freenode because it's the first one in the list. I think it would be more logical for it to auto-select the network of the currently selected room, "baz", which means "irc.gnome.org" in this case.
(In reply to Jean-François Fortin Tam from comment #0) > When I click the + button to join a new room, it defaults to freenode > because it's the first one in the list. No, the join dialog remembers the last account used and uses that as a default the next time the dialog is shown, so it's less arbitrary than simply picking the first list entry. I wouldn't mind changing that to be based on the active channel though. Bastian, what do you think?
(In reply to Florian Müllner from comment #1) > No, the join dialog remembers the last account used and uses that as a > default the next time the dialog is shown, so it's less arbitrary than > simply picking the first list entry. > I wouldn't mind changing that to be based on the active channel though. > Bastian, what do you think? I agree that this would make more sense from a logical standpoint.
(In reply to Bastian Ilsø from comment #2) > (In reply to Florian Müllner from comment #1) > > No, the join dialog remembers the last account used and uses that as a > > default the next time the dialog is shown, so it's less arbitrary than > > simply picking the first list entry. > > I wouldn't mind changing that to be based on the active channel though. > > Bastian, what do you think? > > I agree that this would make more sense from a logical standpoint. I mean, this would *also* make sense and is probably preferred in most cases.
Should make for a nice beginner bug then ...
Created attachment 312735 [details] [review] Use network of the currently selected room
Review of attachment 312735 [details] [review]: Looks mostly good to me, except for those nitpicks: * the 'last-used-account' setting is pointless if we don't use it, so should be removed from to the schema * the commit message should contain line-breaks at 70-76 characters * bonus points for not only describing what the commit does (which should be pretty clear from the code anyway), but also briefly outlining why the change is done
(In reply to Florian Müllner from comment #6) > Review of attachment 312735 [details] [review] [review]: > > Looks mostly good to me, except for those nitpicks: > * the 'last-used-account' setting is pointless if we > don't use it, so should be removed from to the schema Oh I missed that. Thanks > * the commit message should contain line-breaks at > 70-76 characters > * bonus points for not only describing what the commit > does (which should be pretty clear from the code anyway), > but also briefly outlining why the change is done Thanks for the pointers. Will try to be more descriptive.
Created attachment 312848 [details] [review] Use network of the currently selected room
Uh oh, master has changed. I will update patch again.
Created attachment 312849 [details] [review] Use network of the currently selected room
Created attachment 312851 [details] [review] joindialog: Default to account of the currently selected room Looks good to me, thanks - I'll push the patch with a slightly modified commit message (mostly replacing "network" by "account", as we don't use the former anywhere).
Attachment 312851 [details] pushed as 677829c - joindialog: Default to account of the currently selected room