GNOME Bugzilla – Bug 755722
Joining channel with capital letters create two entries - one with small letters and one with as you entered
Last modified: 2015-10-10 23:54:26 UTC
1. Opening Polari; 2. Adding network connection (for example quakenet.org); 3. Opening room (in this example #Elite-Dangerous); 4. Two 'channels' are opened - one with #Elite-Dangerous, another with #elite-dangerous. Active is with small leters, #Elite-Dangerous is empty; Should be reproducable all the time, Fedora 23 with updates here.
Created attachment 312529 [details] [review] room: Minor refactoring Turn update_identifier() into a standard property setter for :display-name instead of tying it directly to :channel-name - the two may soon differ in case.
Created attachment 312530 [details] [review] room: Improve channel-name <-> channel matching When we request a channel, we currently assume that the resulting channel's identifier will match the channel name we used in the request. However as telepathy-idle converts all channel names to lowercase [0], we fail to match names containing uppercase characters to their channel and end up creating a second room for the channel instead. Fix this by using lower-case for both room IDs and channel matching. [0] http://cgit.freedesktop.org/telepathy/telepathy-idle/tree/src/idle-handles.c#n158
Created attachment 312531 [details] [review] app: Factor out _savedChannelIndex() help method We search the list of saved channels for a particular account/channel combination both when adding a saved channel (to avoid duplicate entries) and when removing one (to locate the entry to remove). Consolidate that code in a single place to make future modifications easier.
Created attachment 312532 [details] [review] app: Handle case-mismatches when saving/removing channels While we now match non-lowercase channel names correctly to their corresponding channel, we still (wrongly) assume that requested names match channel identifiers when adding or removing saved channels. Fix this by making the channel matching case-insensitive.
Created attachment 312533 [details] [review] chatroomManager: Use contact alias as channel name if available We use TpContact:alias to represent other users in the user list and elsewhere, so for private conversations it makes for a better channel name than the channel identifier in case the two differ (which may happen as the latter is always lowercase).
Attachment 312529 [details] pushed as 3a578c5 - room: Minor refactoring Attachment 312530 [details] pushed as 597c8c6 - room: Improve channel-name <-> channel matching Attachment 312531 [details] pushed as dbe2395 - app: Factor out _savedChannelIndex() help method Attachment 312532 [details] pushed as 1e9a070 - app: Handle case-mismatches when saving/removing channels Attachment 312533 [details] pushed as 8b4dec5 - chatroomManager: Use contact alias as channel name if available
*** Bug 747974 has been marked as a duplicate of this bug. ***