After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755703 - new gaussian blur: default Abyss policy to Clamp
new gaussian blur: default Abyss policy to Clamp
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
: 755092 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-09-27 18:46 UTC by peter sikking
Modified: 2015-10-12 21:59 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description peter sikking 2015-09-27 18:46:34 UTC
in the new (gegl) gaussian blur, please default the Abyss policy to Clamp so that the results are—by default—the same as for the old gaussian blur (as used up to 2.8, inclusive).

in the UI this will save a lot of users extra clicks.

when using gaussian blur from scripts, this is crucial, because the current (default: None) results are rendering scripts worthless.


ps: bonus points for renaming Abyss policy and Clamp to something that belongs in a graphics application, instead of in Blade Runner. I recommend:

Abyss policy -> Edges
Clamp -> Traditional

(I have no idea what None mode is supposed to do, so no recommendation).
Comment 1 Michael Natterer 2015-09-28 15:29:43 UTC
Indeed, this fixes the compat PDB wrappers for scripts, but I agree the
default value of "None" is less than useful, so is the name "Abyss Policy" ;)

commit 1aeeada2d86ba423983b98bdecfc74a9de242644
Author: Michael Natterer <mitch@gimp.org>
Date:   Mon Sep 28 17:27:29 2015 +0200

    Bug 755703 - new gaussian blur: default Abyss policy to Clamp
    
    Default to CLAMP in the PDB compat wrappers that replace the old
    plug-ins.

 app/pdb/plug-in-compat-cmds.c       | 7 ++++---
 tools/pdbgen/pdb/plug_in_compat.pdb | 7 ++++---
 2 files changed, 8 insertions(+), 6 deletions(-)
Comment 2 Michael Natterer 2015-09-28 15:41:46 UTC
Argh...

commit 0bc3a82c77733388dc3cb91c6aa478a288a18efa
Author: Michael Natterer <mitch@gimp.org>
Date:   Mon Sep 28 17:40:47 2015 +0200

    Bug 755703 - new gaussian blur: default Abyss policy to Clamp
    
    Fix operation name in last commit.

 app/pdb/plug-in-compat-cmds.c       | 2 +-
 tools/pdbgen/pdb/plug_in_compat.pdb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 3 peter sikking 2015-10-01 19:26:27 UTC
(strange, this is the second bug I report and the second time I do not get email when there is action on it. I am on the CCed list)

Mitch, did you also change the default for the normal Filters dialog?
Comment 4 Michael Natterer 2015-10-01 21:51:03 UTC
Not yet, because I didn't meet pippin on IRC since. About your mail
problem, no clue, but I sometimes don't get bugzilla mail for bug
events either.
Comment 5 peter sikking 2015-10-03 17:26:08 UTC
I see my email on the do-not-notify list of these bugs. maybe it is something schumaml set up to get me out of the GIMP bug circuit, earlier this year
Comment 6 Michael Schumacher 2015-10-03 17:32:47 UTC
The default Bugzilla mail notification settings prevent you from getting mails for changes you do yourself. Unless you changed those, you will be on the do-notify list whenever you change anything on a bug report yourself.
Comment 7 Michael Natterer 2015-10-08 16:50:06 UTC
Changing the defaults is a GEGL thing, pippin?
Comment 8 Øyvind Kolås (pippin) 2015-10-09 14:01:04 UTC
Changing the default to none and overriding that default in places where clamp screws things up is probably indeed better. Naming things is hard, and border/edge is probably indeed better than abyss - but for the reason it is hard for programmers to name things; we're somewhat stuck with abyss at least in the API itself, and naming concepts very differently in the UI from the code is not good. On the names of the edge-policies, I think "traditional" is even worse than clamp.
Comment 9 Michael Natterer 2015-10-09 14:30:15 UTC
I suppose you meant "Changing the default to clamp..."?
Comment 10 Øyvind Kolås (pippin) 2015-10-09 14:31:25 UTC
Yep I did, the rest of the first sentence makes little sense otherwise :)
Comment 11 peter sikking 2015-10-09 15:55:26 UTC
@schumaml: FYI, I did not get mail for any of the comments on this bug.

> naming concepts very differently in the UI from the code is not good.

I call that a core service that interaction design performs; translating from a technical world to that of users, in such a way that the product is more valuable.

I admit "traditional" is not brilliant, but I am not designing here and it was suppose to get y’all moving away from clamp and come up with a better name.
Comment 12 Øyvind Kolås (pippin) 2015-10-09 16:01:17 UTC
API design is also interface design, just like GUI design is

GIMP intends to be a high end image manipulation program, and GEGL intends to provide interfaces for programmers to create such a programs. Sophisticated users and developers alike from well chosen vocabulary for realizing their goals. Which is also why a lot of time, but still not enough - has gone into naming things correctly in GEGL - many of these choices also bleed over to the UI.

An additional translation between the technical world to that of users and using different terminology in different places will cause a maintainence burden of combined technical and design debt.
Comment 13 Øyvind Kolås (pippin) 2015-10-09 19:54:48 UTC
commit db4008f9b3719f95c96f894392e78e60fbffd5dc
Author: Øyvind Kolås <pippin@gimp.org>
Date:   Fri Oct 9 21:52:58 2015 +0200

    gaussian-blur: make default abyss policy be clamp
Comment 14 Michael Natterer 2015-10-12 21:59:35 UTC
*** Bug 755092 has been marked as a duplicate of this bug. ***