After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755681 - giscanner: fix alias resolution
giscanner: fix alias resolution
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-26 22:26 UTC by Giovanni Campagna
Modified: 2015-09-27 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
giscanner: fix alias resolution (1.32 KB, patch)
2015-09-26 22:26 UTC, Giovanni Campagna
accepted-commit_now Details | Review

Description Giovanni Campagna 2015-09-26 22:26:56 UTC
Atk has a "typedef GSList AtkAttributeSet", which causes
an ast.Alias() targeting a ast.List(). The latter has a
target_fundamental of '<list>', which cannot be looked
up in ast.type_names (because it's not a real fundamental
type), and that breaks the build.

It turns out that we don't need to find the fundamental
type and then the fundamental type node - the target
field of the ast.Alias already points to the desired
type node.
Comment 1 Giovanni Campagna 2015-09-26 22:26:58 UTC
Created attachment 312220 [details] [review]
giscanner: fix alias resolution
Comment 2 Colin Walters 2015-09-27 18:25:45 UTC
Review of attachment 312220 [details] [review]:

LGTM, thanks!