GNOME Bugzilla – Bug 755656
adaptivedemux: remove unused but set variable
Last modified: 2015-09-30 00:19:56 UTC
Created attachment 312180 [details] [review] diff Remove useless Zombie variable.
diff --git a/gst-libs/gst/adaptivedemux/gstadaptivedemux.c b/gst-libs/gst/adaptivedemux/gstadaptivedemux.c index 9f74c65..f3aabd3 100644 --- a/gst-libs/gst/adaptivedemux/gstadaptivedemux.c +++ b/gst-libs/gst/adaptivedemux/gstadaptivedemux.c @@ -325,7 +325,6 @@ gst_adaptive_demux_init (GstAdaptiveDemux * demux, GstAdaptiveDemuxClass * klass) { GstPadTemplate *pad_template; - GstPad *pad; GST_DEBUG_OBJECT (demux, "gst_adaptive_demux_init"); @@ -355,7 +354,7 @@ gst_adaptive_demux_init (GstAdaptiveDemux * demux, gst_element_class_get_pad_template (GST_ELEMENT_CLASS (klass), "sink"); g_return_if_fail (pad_template != NULL); - demux->sinkpad = pad = gst_pad_new_from_template (pad_template, "sink"); + demux->sinkpad = gst_pad_new_from_template (pad_template, "sink"); gst_pad_set_event_function (demux->sinkpad, GST_DEBUG_FUNCPTR (gst_adaptive_demux_sink_event)); gst_pad_set_chain_function (demux->sinkpad, I posted the diff here. Also, BTW, does anyone give me a hand about how could I create a patch which is visiable? I am a newcomer & make the diff simply by "git diff > diff.patch" but it seems to not visiable under Diff item... Thanks
You should create a commit and attach a 'git format-patch' style patch like so git add files/to/commit git commit <enter commit message> git format-patch -1 Add --help or the search the git documentation for specifics on what these functions do.
Created attachment 312181 [details] [review] diff
In order to commit this, we need the correct author info in the patch. i.e. please fix "From: unknown <r97922153@gmail.com>" to contain your name using git config and reattach the patch.
It's just a small removal, so I've fixed it up. But please fix your git setup for future patches, thanks! commit 40a63d27d86d3b1518946b60fdc2ed7fb3de2a7e Author: John Chang <r97922153@gmail.com> Date: Sat Sep 26 17:02:09 2015 +0800 adaptivedemux: remove unused variable https://bugzilla.gnome.org/show_bug.cgi?id=755656
Dear Müller Thank you for your help and inform~