After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755656 - adaptivedemux: remove unused but set variable
adaptivedemux: remove unused but set variable
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
Other Windows
: Normal minor
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-09-26 07:35 UTC by WeiChungChang
Modified: 2015-09-30 00:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

diff (1.91 KB, patch)
2015-09-26 07:35 UTC, WeiChungChang
none Details | Review
diff (1.26 KB, patch)
2015-09-26 09:07 UTC, WeiChungChang
committed Details | Review

Description WeiChungChang 2015-09-26 07:35:40 UTC
Created attachment 312180 [details] [review]

Remove useless Zombie variable.
Comment 1 WeiChungChang 2015-09-26 08:32:23 UTC
diff --git a/gst-libs/gst/adaptivedemux/gstadaptivedemux.c b/gst-libs/gst/adaptivedemux/gstadaptivedemux.c
index 9f74c65..f3aabd3 100644
--- a/gst-libs/gst/adaptivedemux/gstadaptivedemux.c
+++ b/gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ -325,7 +325,6 @@ gst_adaptive_demux_init (GstAdaptiveDemux * demux,
     GstAdaptiveDemuxClass * klass)
   GstPadTemplate *pad_template;
-  GstPad *pad;
   GST_DEBUG_OBJECT (demux, "gst_adaptive_demux_init");
@@ -355,7 +354,7 @@ gst_adaptive_demux_init (GstAdaptiveDemux * demux,
       gst_element_class_get_pad_template (GST_ELEMENT_CLASS (klass), "sink");
   g_return_if_fail (pad_template != NULL);
-  demux->sinkpad = pad = gst_pad_new_from_template (pad_template, "sink");
+  demux->sinkpad = gst_pad_new_from_template (pad_template, "sink");
   gst_pad_set_event_function (demux->sinkpad,
       GST_DEBUG_FUNCPTR (gst_adaptive_demux_sink_event));
   gst_pad_set_chain_function (demux->sinkpad,

I posted the diff here.
Also, BTW, does anyone give me a hand about how could I create a patch which is visiable?
I am a newcomer & make the diff simply by "git diff > diff.patch" but it seems to not visiable under Diff item...

Comment 2 Matthew Waters (ystreet00) 2015-09-26 08:52:26 UTC
You should create a commit and attach a 'git format-patch' style patch like so

git add files/to/commit
git commit
<enter commit message>
git format-patch -1

Add --help or the search the git documentation for specifics on what these functions do.
Comment 3 WeiChungChang 2015-09-26 09:07:16 UTC
Created attachment 312181 [details] [review]
Comment 4 Matthew Waters (ystreet00) 2015-09-28 12:56:12 UTC
In order to commit this, we need the correct author info in the patch.  i.e. please fix "From: unknown <>" to contain your name using git config and reattach the patch.
Comment 5 Tim-Philipp Müller 2015-09-29 13:45:44 UTC
It's just a small removal, so I've fixed it up. But please fix your git setup for future patches, thanks!

commit 40a63d27d86d3b1518946b60fdc2ed7fb3de2a7e
Author: John Chang <>
Date:   Sat Sep 26 17:02:09 2015 +0800

    adaptivedemux: remove unused variable
Comment 6 WeiChungChang 2015-09-30 00:19:56 UTC
Dear Müller

Thank you for your help and inform~