After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755625 - wayland: support dnd actions
wayland: support dnd actions
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.18.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
: 735849 756656 758392 758745 (view as bug list)
Depends on:
Blocks: WaylandRelated
 
 
Reported: 2015-09-25 13:29 UTC by Berend De Schouwer
Modified: 2017-04-18 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Berend De Schouwer 2015-09-25 13:29:14 UTC
Moving a message from inbox to another folder copies the message to the new folder.  It does not delete the original, so it ends up being a copy instead of a move.

Tested on gmail and imap (imapx)
Comment 1 Milan Crha 2015-09-29 12:03:57 UTC
Thanks for a bug report. i tried to reproduce this with current git master, which is pretty much the same as to-be 3.18.1, and the move on GMail server using IMAPx works just fine.

My steps:
a) create folder Inbox/test
b) create folder Inbox/test/test2
c) copy one message into Inbox/test
d) move one message from Inbox/test into Inbox/test/test2 using drag&drop

The message is moved, not copied. Furthermore, the GMail server supports
UID MOVE command, thus it takes care of the move, not the evolution. When I run evolution from a command line like: 
   $ CAMEL_DEBUG=imapx:io evolution
then after the step d) I see the move command there, which looks like:

> A00051 OK [READ-WRITE] INBOX/test selected. (Success)'
> [imapx:A] I/O: 'A00052 UID MOVE 1 INBOX/test/test2'
> [imapx:A] I/O: '* 1 EXPUNGE
> * 0 EXISTS
> A00052 OK [COPYUID 58 1 1] (Success)'

which is just as it should be.

There is a related issue fix [1], committed for 3.17.92, but as you have filled that you use 3.18.x, then you should have the fix included already. That is in the evolution-data-server.

Could you verify your evolution-data-server version and paste it here, please? Could you run the evolution from a terminal with the CAMEL_DEBUG as shown above, and copy&paste the command being run from the time of the message move, please? Maybe you do other steps, and they behave differently?

[1] https://git.gnome.org/browse/evolution-data-server/commit/?id=73d0803
Comment 2 Berend De Schouwer 2015-09-29 15:45:46 UTC
I've tested some more, and it seems I cannot duplicate it under X11, but I can under Wayland.

The text written in the status bar under X11 is "Moving messages to folder ...", the text written under Wayland is "Copying messages to folder ..."

Might be a GTK+ drag-and-drop problem?

I'll get CAMEL_DEBUG as soon as I run Wayland again.  Not today.
Comment 3 Milan Crha 2015-09-30 05:18:46 UTC
(In reply to Berend De Schouwer from comment #2)
> Might be a GTK+ drag-and-drop problem?

Under Wayland, I see. I agree with the above statement, it really might be something wrong in a lower level, like the gtk+. I'm moving this there.

No need to capture the CAMEL_DEBUG log, the Wayland thing explains it.
Comment 4 Daniel Stone 2015-09-30 08:02:06 UTC
Yeah, I'd agree; see https://bugs.freedesktop.org/show_bug.cgi?id=91944
Comment 5 Carlos Garnacho 2015-09-30 09:49:31 UTC
Yeah exactly, there is currently no concept of "actions" during DnD operations, I made GTK+ default to "copy" as that's less prone to result unexpected behavior or data loss. 

There's already wayland proposals around adding the missing actions, plus branches for mutter and GTK+ that'd make things just work.
Comment 6 Matthias Clasen 2015-11-17 20:59:36 UTC
*** Bug 735849 has been marked as a duplicate of this bug. ***
Comment 7 Carlos Soriano 2015-11-26 11:47:39 UTC
*** Bug 758392 has been marked as a duplicate of this bug. ***
Comment 8 Milan Crha 2015-11-30 12:09:45 UTC
*** Bug 758745 has been marked as a duplicate of this bug. ***
Comment 9 Matthias Clasen 2016-01-23 04:56:56 UTC
this has landed now
Comment 10 Leo 2016-03-12 12:37:27 UTC
Does this mean it has been corrected?

When will it be available?
Comment 11 Christian Stadelmann 2016-03-12 21:35:18 UTC
(In reply to Leo from comment #10)
> Does this mean it has been corrected?
> 
> When will it be available?

In Gtk+ 3.20 or its prereleases, 3.19.x
Comment 12 Berend De Schouwer 2016-05-19 08:13:42 UTC
This seems to be fixed in Nautilus, but not evolution

nautilus 3.20
evolution 3.20.2

evolution always says 'copying'
Comment 13 Matthias Clasen 2016-05-19 13:16:54 UTC
that needs to be analyzed on the evolution side first.
Comment 14 Berend De Schouwer 2016-05-19 13:23:02 UTC
(In reply to Matthias Clasen from comment #13)
> that needs to be analyzed on the evolution side first.

Apologies.  I originally marked this bug against evolution.
Comment 15 Milan Crha 2016-06-23 08:10:52 UTC
Works for me, evolution-3.20.3, the only difference is that the default action under X is move, while the default action under Wayland is copy, which can be changes using the Shift, respectively Control, key while dragging the item.
Comment 16 Christian Stadelmann 2016-06-23 08:24:21 UTC
@mcrha: Can you please make dnd default to move again? Copying mails is quite uncommon, moving them is not.
Comment 17 Christian Stadelmann 2016-06-24 15:47:45 UTC
(In reply to Christian Stadelmann from comment #16)
> @mcrha: Can you please make dnd default to move again? Copying mails is
> quite uncommon, moving them is not.

I've filed a separate bug: #768013
Comment 18 Carlos Soriano 2017-04-18 09:50:49 UTC
*** Bug 756656 has been marked as a duplicate of this bug. ***