After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755616 - Unable to build xwayland on Fedora 22
Unable to build xwayland on Fedora 22
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2015-09-25 08:57 UTC by Andreas Nilsson
Modified: 2015-09-26 14:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix the issue (1.25 KB, patch)
2015-09-26 13:02 UTC, Andreas Nilsson 		none Details | Review

Description Andreas Nilsson 2015-09-25 08:57:05 UTC 
I was trying to run "jhbuild build" on Fedora 22, but it got stuck at building xwayland, due to a xproto dependency. It seems the sysdeps command didn't take care of that.

It might also be that my distro is too old.

http://pastebin.com/MTf463Ma
Comment 1 Andreas Nilsson 2015-09-25 10:27:53 UTC 
This is the out put of "jhbuild sysdeps --install xwayland"

http://pastebin.com/0yT67zdu
Comment 2 Javier Jardón (IRC: jjardon) 2015-09-25 11:40:42 UTC 
I wonder if we should depend on xserver 1.16 (which includes xwayland) instead build this ourselves
Comment 3 Emmanuele Bassi (:ebassi) 2015-09-25 15:41:18 UTC 
I think this is just a case of missing deps — just adding xorg-xproto to the xwayland dependencies is enough.

(In reply to Javier Jardón (IRC: jjardon) from comment #2)
> I wonder if we should depend on xserver 1.16 (which includes xwayland)
> instead build this ourselves

Which version of the X server RHEL, CentOS, Debian stable, and Ubuntu LTS ship?
Comment 4 Andreas Nilsson 2015-09-25 16:54:32 UTC 
(In reply to Emmanuele Bassi (:ebassi) from comment #3)
> I think this is just a case of missing deps — just adding xorg-xproto to the
> xwayland dependencies is enough.

Seems like it.
I added this to gnome-suite-core-deps-3.18.modules on around 1278

  <autotools id="xorg-xproto">
    <pkg-config>xproto.pc</pkg-config>
    <branch repo="xorg-tar"
            module="releases/individual/proto/xproto-7.0.28.tar.gz" version="7.0.28"
            size="367523"
            hash="8f8a716d6daa6ba05df97d513960d35a39e040600bf04b313633f11679006fab"/>
  </autotools>

and

<dep package="xorg-xproto"/> on line 1314
and it did the trick! xwayland built successfully.
Comment 5 Andreas Nilsson 2015-09-25 17:03:16 UTC 
The hash is completely wrong of course. How do I find that one out so I can create a correct patch?
Comment 6 Andreas Nilsson 2015-09-25 21:09:37 UTC 
I did md5sum xproto-7.0.28.tar.gz 
and got 0b42843b99aee3e4f6a9cc7710143f86
Is that the correct checksum?
Comment 7 Andreas Nilsson 2015-09-26 13:02:36 UTC 
Created attachment 312200 [details] [review]
patch to fix the issue

Found the SHA256 here:
http://lists.x.org/archives/xorg-announce/2015-July/002618.html

I hope this patch is correct.
Comment 8 Javier Jardón (IRC: jjardon) 2015-09-26 14:16:35 UTC 
Hi Andreas,

thank you very much for the patch. I've split it as there were 2 bugs here:

- The dependency of xwayland in xorg-xproto was not set
- The version required is probably too new for some distros, so I've moved the module from -sysdeps to -core-deps

Check 6931f133185b6fea8b9bc14aea09d56602c51623 and the previous 2 commits