After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755580 - PATCH - error extracting files using file-roller with unar with the character [
PATCH - error extracting files using file-roller with unar with the character [
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: file-roller-maint
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-24 20:00 UTC by ZenWalker
Modified: 2015-09-25 06:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for debian (636 bytes, patch)
2015-09-24 20:00 UTC, ZenWalker
none Details | Review

Description ZenWalker 2015-09-24 20:00:12 UTC
Created attachment 312085 [details] [review]
patch for debian

More info:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769225

Here is a patch that solves this bug:

diff --git a/src/fr-command-unarchiver.c b/src/fr-command-unarchiver.c
index 27d3382..714bf29 100644
--- a/src/fr-command-unarchiver.c
+++ b/src/fr-command-unarchiver.c
@@ -205,8 +205,13 @@ fr_command_unarchiver_extract (FrCommand  *comm,

 	fr_process_add_arg (comm->process, comm->filename);

-	for (scan = file_list; scan; scan = scan->next)
-		fr_process_add_arg (comm->process, scan->data);
+	for (scan = file_list; scan; scan = scan->next) {
+		char *escaped;
+
+ 		escaped = _g_str_escape (scan->data, "[");
+ 		fr_process_add_arg (comm->process, escaped);
+ 		g_free (escaped);
+	}

 	fr_process_end_command (comm->process);
 }
Comment 1 Paolo Bacchilega 2015-09-25 06:50:48 UTC
Patch applied, thank you.