After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755459 - gtksink: Do not show window until we reach the PAUSED state
gtksink: Do not show window until we reach the PAUSED state
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.6.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-23 09:55 UTC by Thibault Saunier
Modified: 2015-09-23 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtksink: Do not show window until we reach the PAUSED state (1.62 KB, patch)
2015-09-23 09:55 UTC, Thibault Saunier
committed Details | Review

Description Thibault Saunier 2015-09-23 09:55:25 UTC
Otherwise we might be showing an empty window in READY even though going
to ready is actually going to fail later
Comment 1 Thibault Saunier 2015-09-23 09:55:31 UTC
Created attachment 311932 [details] [review]
gtksink: Do not show window until we reach the PAUSED state
Comment 2 Thibault Saunier 2015-09-23 10:08:24 UTC
Attachment 311932 [details] pushed as 3417a15 - gtksink: Do not show window until we reach the PAUSED state
Comment 3 Nicolas Dufresne (ndufresne) 2015-09-23 13:57:25 UTC
I wonder why do we care ? This window thing is not going to be used in any application other then gst-launch. So that the window pop black early is really minor thing imho.
Comment 4 Thibault Saunier 2015-09-23 14:23:02 UTC
(In reply to Nicolas Dufresne (stormer) from comment #3)
> I wonder why do we care ? This window thing is not going to be used in any
> application other then gst-launch. So that the window pop black early is
> really minor thing imho.

It will be used if we try to go to READY to check if we can use the sink.
Comment 5 Nicolas Dufresne (ndufresne) 2015-09-23 14:39:36 UTC
Ok, fair, so you are doing that to choose between GL and Cairo ?
Comment 6 Thibault Saunier 2015-09-23 14:47:24 UTC
Yes.