After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755417 - nlecomposition allocates unused UpdateCompositionData
nlecomposition allocates unused UpdateCompositionData
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal normal
: 1.6.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-22 14:15 UTC by Justin Kim
Modified: 2015-09-24 11:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
nlecomposition and nleobject: trivial leakages (2.71 KB, patch)
2015-09-22 14:16 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2015-09-22 14:15:43 UTC 
Allocated pointer which is never used causes leakage.
Comment 1 Justin Kim 2015-09-22 14:16:22 UTC 
Created attachment 311863 [details] [review]
nlecomposition and nleobject: trivial leakages
Comment 2 Justin Kim 2015-09-24 08:52:04 UTC 
Review of attachment 311863 [details] [review]:

::: plugins/nle/nlecomposition.c
@@ -2877,1 @@
 

@Thibault Saunier,
Could you check this code also?

I'm curious to know if some codes are omitted to handle ucompo, or we can just remove this allocation.
Comment 3 Thibault Saunier 2015-09-24 10:10:45 UTC 
Review of attachment 311863 [details] [review]:

Please update the patch and it looks good. Thanks :)

::: plugins/nle/nlecomposition.c
@@ -2877,1 @@
 

Very useless piece of code indeed, go ahead and remove it please :)
Comment 4 Justin Kim 2015-09-24 10:57:14 UTC 
Review of attachment 311863 [details] [review]:

::: plugins/nle/nlecomposition.c
@@ -2877,1 @@
 

Yes, It's been removed in my proposed patch. :)
Comment 5 Thibault Saunier 2015-09-24 11:05:26 UTC 
Review of attachment 311863 [details] [review]:

::: plugins/nle/nlecomposition.c
@@ -2877,1 @@
 

I got lost in my reviews, sorry, all good then :)
Comment 6 Thibault Saunier 2015-09-24 11:07:18 UTC 
commit bd1d03202bdd278df7db3558e9df49082ade485d
Author: Justin Kim <justin.kim@collabora.com>
Date:   Tue Sep 22 23:10:35 2015 +0900

    nle{composition,object}: remove unused allocation & trivial leakages
    
    nlecomposition allocates unused 'UpdateCompositionData' and it
    causes leakages.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755417