After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755389 - build-sys: Cannot build without GObject introspection
build-sys: Cannot build without GObject introspection
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.52.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2015-09-22 07:52 UTC by Quentin "Sardem FF7" Glidic
Modified: 2016-03-23 16:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix non-introspection build (1011 bytes, patch)
2015-09-22 07:53 UTC, Quentin "Sardem FF7" Glidic 		committed Details | Review

Description Quentin "Sardem FF7" Glidic 2015-09-22 07:52:04 UTC 
While building libsoup without GObject introspection, it complains about a missing Automake conditional, "ENABLE_VAPIGEN".

Said conditional is hidden in the "if test x$found_introspection = xyes" while VAPIGEN_CHECK is already doing such a check.

There is no point in doing this check, as it is doing the exact opposite of what it is trying to achieve.
Comment 1 Quentin "Sardem FF7" Glidic 2015-09-22 07:53:17 UTC 
Created attachment 311830 [details] [review]
Patch to fix non-introspection build
Comment 2 Dan Winship 2015-09-23 15:32:32 UTC 
thanks
Comment 3 Andres Gomez 2016-03-23 15:57:33 UTC 
The behavior now is a bit weird.

If we only pass "--disable-introspection" we will get an error of the form:

"
...
checking for gobject-introspection... no (disabled, use --enable-introspection to enable)
checking for valac... /home/tanty/no-backup/personal/webkit/epiphany/install/bin/valac
configure: error: Vala bindings require GObject Introspection
"

So, in addition, we would have to pass "--disable-vala".

I think it would be better to already set "--disable-vala" if "--disable-introspection" is also set.

Not sure this is not a bug in vala's "vapigen.m4", though.

Opinions?
Comment 4 Andres Gomez 2016-03-23 16:40:40 UTC 
Reported in bug 764090