GNOME Bugzilla – Bug 755386
Can't add Pocket account via Firefox account
Last modified: 2016-07-21 18:22:54 UTC
You may know that it's possible to sign into Pocket using a Firefox account, as part of Mozilla embedding Pocket support into Firefox. (This works just like signing into Pocket using a Google account.) But I can't authorize GOA to access my Pocket account this way. Steps to reproduce: 1. Open the Online Accounts page in Control Center 2. Add Account → Pocket 3. On the “Log In and Authorize” page, choose “Log In with Firefox” 4. On the Firefox Account sign-in page, fill in credentials I'd expect that now, either the dialog would just close, or I'd be re-prompted to authorize GNOME to access my Pocket account. But instead, I'm just shown my Pocket bookmarks within the GOA auth dialog, and https://getpocket.com/connected_applications confirms that GOA hasn't been authorized. Not sure whether this is Pocket's fault (totally possible!) or GOA's. I'm using gnome-online-accounts-3.16.3-1.fc22.x86_64 and control-center-3.16.3-1.fc22.x86_64
I can still confirm this issue on Gnome 3.20
When using a Firefox account, Pocket doesn't redirect to the redirect_uri specified by us and it breaks. Interestingly, this is not documented in https://getpocket.com/developer/docs/authentication However, I found this slide deck that explains how to use a Firefox account with Pocket: http://www.slideshare.net/KuoE0/pocket-authentication-with-oauth-on-firefox-os
Created attachment 331786 [details] [review] pocket: Update README
I am working on this in gnome-online-accounts:wip/rishi/pocket-firefox. It is taking longer than it should because I ran into an issue with webkit2.h and webkit-web-extension.h. Some of the GoaProvider vfuncs are run in the UI process and the others in the web extension process, but WebKit2 explicitly prevents us from mixing up the headers in the same translation unit.
Created attachment 331905 [details] [review] oauth2: Split the WebKitDOM* symbols out of the main header
Created attachment 331906 [details] [review] oauth2: Add a new vfunc to influence the navigation policy
Created attachment 331907 [details] [review] oauth2: Call goa_oauth2_provider_decide_navigation_policy
Created attachment 331908 [details] [review] pocket: Reuse authorization URI
Created attachment 331909 [details] [review] pocket: Support logging in with a Firefox account
Pushed to master. The changes are a bit intrusive, so I don't want to put them in gnome-3-20 without some testing.