After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755363 - Non-void function should return a value
Non-void function should return a value
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2015-09-21 17:19 UTC by Ting-Wei Lan
Modified: 2015-09-21 18:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ting-Wei Lan 2015-09-21 17:19:56 UTC 
Function gimp_tool_gui_get_visible in app/display/gimptoolgui.c has a return value, so it cannot use g_return_if_fail. It should use g_return_val_if_fail.
Comment 1 Michael Natterer 2015-09-21 18:38:57 UTC 
Thanks. There must be something seriously broken with my gcc, it did
warn about this before some recent update...

commit 526a3a6020fe19e5c2361e93306006bf1cccc7f4
Author: Michael Natterer <mitch@gimp.org>
Date:   Mon Sep 21 20:37:29 2015 +0200

    Bug 755363 - Non-void function should return a value
    
    Use g_return_val_if_fail() in function returning non-void.

 app/display/gimptoolgui.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Ting-Wei Lan 2015-09-21 18:44:09 UTC 
This should be a glib bug: https://bugzilla.gnome.org/show_bug.cgi?id=753310