After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755355 - Move GStrv to glib.h so it can be used with g_auto()
Move GStrv to glib.h so it can be used with g_auto()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-09-21 14:43 UTC by Xavier Claessens
Modified: 2015-09-22 15:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move GStrv typedef to glib.h instead of gobject.h (4.92 KB, patch)
2015-09-21 14:43 UTC, Xavier Claessens 		none Details | Review
Move GStrv typedef to glib.h instead of gobject.h (4.99 KB, patch)
2015-09-21 15:04 UTC, Xavier Claessens 		committed Details | Review

Description Xavier Claessens 2015-09-21 14:43:25 UTC 
.
Comment 1 Xavier Claessens 2015-09-21 14:43:41 UTC 
Created attachment 311762 [details] [review]
Move GStrv typedef to glib.h instead of gobject.h

GStrv was historically only needed for the boxed G_TYPE_STRV,
but it is now useful for g_auto(GStrv) as well. This is not
an ABI change.
Comment 2 Allison Karlitskaya (desrt) 2015-09-21 14:52:15 UTC 
Review of attachment 311762 [details] [review]:

Looks good.  Thanks for the bonus test :)

::: docs/reference/glib/glib-sections.txt
@@ +1444,2 @@
 <SUBSECTION>
+GStrv

can you find somewhere more useful to put this?  maybe move it down to above the g_strv_length/contains and split the three of them off into their own <SUBSECTION> ?
Comment 3 Xavier Claessens 2015-09-21 15:04:16 UTC 
Created attachment 311766 [details] [review]
Move GStrv typedef to glib.h instead of gobject.h

GStrv was historically only needed for the boxed G_TYPE_STRV,
but it is now useful for g_auto(GStrv) as well. This is not
an ABI change.
Comment 4 Xavier Claessens 2015-09-21 15:05:04 UTC 
SUBSECTION doesn't have any impact anymore since the new gtkdoc style AFAIK. But I agree they belong together.
Comment 5 Allison Karlitskaya (desrt) 2015-09-22 15:02:39 UTC 
Review of attachment 311766 [details] [review]:

looks good now.  thanks.
Comment 6 Xavier Claessens 2015-09-22 15:18:59 UTC 
Attachment 311766 [details] pushed as b81f3ce - Move GStrv typedef to glib.h instead of gobject.h