After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755294 - GeditCloseConfirmationDialog is broken
GeditCloseConfirmationDialog is broken
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: file loading and saving
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
: 755420 755519 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-09-20 07:42 UTC by Arnaud B.
Modified: 2015-09-24 10:01 UTC
See Also:
GNOME target: 3.18
GNOME version: ---

Attachments
Screenshot, when closing the window with an unsaved file. (135.43 KB, image/png)
2015-09-20 07:42 UTC, Arnaud B. 		  Details
close-confirmation-dialog: fix property name (1.57 KB, patch)
2015-09-20 08:21 UTC, sébastien lafargue 		none Details | Review

Description Arnaud B. 2015-09-20 07:42:49 UTC 
Created attachment 311692 [details]
Screenshot, when closing the window with an unsaved file.

Looks like the the GeditCloseConfirmationDialog is broken in 3.17.92…

sys:1: Warning: g_param_spec_internal: assertion '!(flags & G_PARAM_STATIC_NAME) || is_canonical (name)' failed
sys:1: Warning: g_object_class_install_properties: assertion 'pspec != NULL' failed
sys:1: Warning: g_object_new_valist: object class 'GeditCloseConfirmationDialog' has no property named 'unsaved_documents'
Comment 1 sébastien lafargue 2015-09-20 08:21:44 UTC 
Created attachment 311694 [details] [review]
close-confirmation-dialog: fix property name

fix non-valid property name with an underscore.
Comment 2 Paolo Borelli 2015-09-20 08:52:32 UTC 
Uhm, weird, I thought the policy of glib was to accept _ even if - is the preferred form.

Anyway the patch looks good: please ask permission to the release team for the code freeze break (either on irc or by mail) and let's get this in 3.18.9
Comment 3 Paolo Borelli 2015-09-20 09:01:26 UTC 
(obviously I meant 3.18.0)
Comment 4 sébastien lafargue 2015-09-21 11:22:38 UTC 
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.

commited as 466722b
Comment 5 Paolo Borelli 2015-09-22 16:48:07 UTC 
*** Bug 755420 has been marked as a duplicate of this bug. ***
Comment 6 sébastien lafargue 2015-09-24 10:01:14 UTC 
*** Bug 755519 has been marked as a duplicate of this bug. ***