After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755268 - [HighContrast] GtkPlacesSidebar’s “eject” button should probably be themed
[HighContrast] GtkPlacesSidebar’s “eject” button should probably be themed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-09-19 18:33 UTC by Arnaud B.
Modified: 2015-09-24 03:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot. See “gobelin”. (25.10 KB, image/png)
2015-09-19 18:33 UTC, Arnaud B. 		  Details
HC: use round buttons on sidebars (13.08 KB, patch)
2015-09-22 22:56 UTC, Jakub Steiner 		committed Details | Review

Description Arnaud B. 2015-09-19 18:33:38 UTC 
Created attachment 311676 [details]
Screenshot. See “gobelin”.

When using the HighContrast theme, the “eject” button located at the right of a removable media entry in the GtkPlacesSidebar looks like an usual square button. In Adwaita, it’s a round button that reveals itself on hover.

I think playing with hover is not a good idea in the HighContrast theme, but it doesn’t look great now. Couldn’t it be just a round button?
Comment 1 Matthias Clasen 2015-09-19 19:50:27 UTC 
dunno. looks ok to me.
Comment 2 Jakub Steiner 2015-09-22 22:56:02 UTC 
Created attachment 311913 [details] [review]
HC: use round buttons on sidebars

Copy Adwaita in how sidebar icon buttons look
Comment 3 Matthias Clasen 2015-09-24 03:42:42 UTC 
Attachment 311913 [details] pushed as 9dfa8e2 - HC: use round buttons on sidebars