After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755225 - On Windows, generated layout is with UNIX EOL (patch included)
On Windows, generated layout is with UNIX EOL (patch included)
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.8.11-GIT
Other Windows
: Normal minor
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2015-09-18 14:55 UTC by GeorgesZ
Modified: 2015-12-30 10:20 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description GeorgesZ 2015-09-18 14:55:20 UTC
On Windows, the layout file is with UNIX EOL. I believe the fix should be trivial. See below in Git Extensions diff format. I can also provide it as a pull request at https://github.com/doxygen/doxygen. Let me know.

Thanks,
Georges

diff --git a/src/layout.cpp b/src/layout.cpp
index 01d5d18..1d778a6 100644
--- a/src/layout.cpp
+++ b/src/layout.cpp
@@ -1396,7 +1396,7 @@ void LayoutDocManager::parse(QTextStream &t,const char *fileName)
 void writeDefaultLayoutFile(const char *fileName)
 {
   QFile f(fileName);
-  if (!f.open(IO_WriteOnly))
+  if (!f.open(IO_WriteOnly | QIODevice::Text))
   {
     err("Failed to open file %s for writing!\n",fileName);
     return;
Comment 1 Dimitri van Heesch 2015-09-20 13:55:26 UTC
Thanks, the patch itself doesn't compile, but I'll include a similar fix in the next GIT update.
Comment 2 Dimitri van Heesch 2015-12-30 10:20:14 UTC
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.11. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information 
that you think can be relevant (preferably in the form of a self-contained example).