After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755173 - deploying java class from plugin
deploying java class from plugin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other All
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 737786
Blocks:
 
 
Reported: 2015-09-17 17:04 UTC by Justin Kim
Modified: 2015-10-20 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
packaging java class (2.31 KB, patch)
2015-09-17 17:05 UTC, Justin Kim 		none Details | Review
packaging java class files (1.29 KB, patch)
2015-10-15 21:26 UTC, Justin Kim 		none Details | Review
replaced with '+=' (1.30 KB, patch)
2015-10-16 07:10 UTC, Justin Kim 		none Details | Review
string array (1.31 KB, patch)
2015-10-16 10:22 UTC, Justin Kim 		accepted-commit_now Details | Review

Description Justin Kim 2015-09-17 17:04:29 UTC 
With android camera patch of gst-plugins-bad, java class file will be located in share directory (datadir). However, cerbero seems to miss the file when packaging.
Comment 1 Justin Kim 2015-09-17 17:05:17 UTC 
Created attachment 311573 [details] [review]
packaging java class
Comment 2 Sebastian Dröge (slomo) 2015-10-14 14:05:13 UTC 
Comment on attachment 311573 [details] [review]
packaging java class

It's enough to do it in one of the two recipes. I would vote for the non-static one.
Comment 3 Justin Kim 2015-10-15 21:26:00 UTC 
Created attachment 313404 [details] [review]
packaging java class files

only static recipe set file_devel variable.
Comment 4 Sebastian Dröge (slomo) 2015-10-16 06:20:34 UTC 
Comment on attachment 313404 [details] [review]
packaging java class files

Can go in after the other part is merged.


We use += in other places, and also usually don't put a space before opening parenthesis in Python
Comment 5 Justin Kim 2015-10-16 07:10:31 UTC 
Created attachment 313415 [details] [review]
replaced with '+='
Comment 6 Sebastian Dröge (slomo) 2015-10-16 07:21:21 UTC 
Review of attachment 313415 [details] [review]:

::: recipes/gst-plugins-bad-1.0-static.recipe
@@ +184,3 @@
+        if self.config.target_platform == Platform.ANDROID:
+            self.files_devel += \
+                'share/gst-android/ndk-build'

That's not how this works:
>>> foo=[]
>>> foo+='bla'
>>> foo
['b', 'l', 'a']

You have to use += ['share/...']
Comment 7 Justin Kim 2015-10-16 10:22:46 UTC 
Created attachment 313445 [details] [review]
string array

Whew, sorry for disturbing you. Now I remember why I used "append" instead of "+=". 

Thank you very much for reviewing kindly.
Comment 8 Matthew Waters (ystreet00) 2015-10-20 17:58:25 UTC 
Thanks!

commit cedbf84355a9122612018b8c0560608d5f855676
Author: Justin Kim <justin.kim@collabora.com>
Date:   Fri Oct 16 06:21:52 2015 +0900

    gst-plugins-bad-1.0: copy java class into package
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755173