After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755171 - libs: initializes miniobject memory to zero
libs: initializes miniobject memory to zero
Status: RESOLVED NOTABUG
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other All
: Low enhancement
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-17 16:58 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-10-19 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libs: initializes miniobject memory to zero (1.16 KB, patch)
2015-09-17 16:58 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Description Víctor Manuel Jáquez Leal 2015-09-17 16:58:12 UTC 
This patch replaces the call to g_slice_alloc() to gst_slice_alloc0(),
which initializes the allocated memory to 0, making it safer to use.

Doing a perf measurement with a simple H264 1080p video, the overhead of
this call goes from 0.05% to 0.09%
Comment 1 Víctor Manuel Jáquez Leal 2015-09-17 16:58:16 UTC 
Created attachment 311572 [details] [review]
libs: initializes miniobject memory to zero
Comment 2 sreerenj 2015-09-17 17:14:23 UTC 
(In reply to Víctor Manuel Jáquez Leal from comment #0)
> This patch replaces the call to g_slice_alloc() to gst_slice_alloc0(),
> which initializes the allocated memory to 0, making it safer to use.
> 
> Doing a perf measurement with a simple H264 1080p video, the overhead of
> this call goes from 0.05% to 0.09%

Just curious, did you hit any bug related with this?
Comment 3 Víctor Manuel Jáquez Leal 2015-09-17 17:53:22 UTC 
(In reply to sreerenj from comment #2)
> (In reply to Víctor Manuel Jáquez Leal from comment #0)
> > This patch replaces the call to g_slice_alloc() to gst_slice_alloc0(),
> > which initializes the allocated memory to 0, making it safer to use.
> > 
> > Doing a perf measurement with a simple H264 1080p video, the overhead of
> > this call goes from 0.05% to 0.09%
> 
> Just curious, did you hit any bug related with this?

Just as a generalization of bug 754845
Comment 4 Víctor Manuel Jáquez Leal 2015-09-24 10:18:00 UTC 
As the main advantage of gstvaapiminiobject is the reduction of overhead compared with GObject and GstMiniObject, this patch would make no sense.

I'm closing it as not a bug.