After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755168 - owncloud, exchange: Sanitize HTTP error messages
owncloud, exchange: Sanitize HTTP error messages
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-17 16:50 UTC by Debarshi Ray
Modified: 2015-10-01 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ewsclient, httpclient, utils: Sanitize SOUP_STATUS_UNAUTHORIZED (3.76 KB, patch)
2015-09-17 16:57 UTC, Debarshi Ray
committed Details | Review
utils: Sanitize name resolution failures and wrong server values (1.85 KB, patch)
2015-10-01 16:33 UTC, Debarshi Ray
committed Details | Review
Updated POTFILES.in and removed redundant includes (1.23 KB, patch)
2015-10-01 17:47 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-09-17 16:50:55 UTC
When adding an ownCloud or Exchange account, if anything goes wrong we show something cryptic like:
"Code: 401 — Unexpected response from server"

We should show something more human readable than the underlying HTTP status code.
Comment 1 Debarshi Ray 2015-09-17 16:57:19 UTC
Created attachment 311571 [details] [review]
ewsclient, httpclient, utils: Sanitize SOUP_STATUS_UNAUTHORIZED

This uses a pre-existing string. Hence suitable for string-frozen branches.
Comment 2 Debarshi Ray 2015-10-01 16:33:54 UTC
Created attachment 312510 [details] [review]
utils: Sanitize name resolution failures and wrong server values
Comment 3 Debarshi Ray 2015-10-01 16:36:40 UTC
This should take care of the most common errors. We can handle more if the need arises.
Comment 4 Debarshi Ray 2015-10-01 17:47:04 UTC
Created attachment 312521 [details] [review]
Updated POTFILES.in and removed redundant includes