After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755136 - search box dissapears
search box dissapears
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-16 22:33 UTC by Andreas Nilsson
Modified: 2015-09-17 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
before pressing "local" (88.30 KB, image/png)
2015-09-16 22:33 UTC, Andreas Nilsson
  Details
after pressing "local" (99.63 KB, image/png)
2015-09-16 22:34 UTC, Andreas Nilsson
  Details
GdTaggedEntry: Add a missing gtk_style_context_restore() (1.02 KB, patch)
2015-09-17 18:58 UTC, Benjamin Otte (Company)
committed Details | Review

Description Andreas Nilsson 2015-09-16 22:33:20 UTC
Created attachment 311512 [details]
before pressing "local"

The search box dissapear when presssing "local"
Comment 1 Andreas Nilsson 2015-09-16 22:34:07 UTC
Created attachment 311513 [details]
after pressing "local"

text box dissapears
Comment 2 Bastien Nocera 2015-09-17 00:15:40 UTC
This is a theme problem, isn't it? I can't reproduce it on Fedora 22, but can in jhbuild. Totem's code for 3.17.92 and 3.16.4 has not changed.
Comment 3 Andreas Nilsson 2015-09-17 10:06:35 UTC
I didn't see it in Photos, so I was unsure if it was a theme issue or not, but if the code is the same, it sounds very much like a theme issue indeed.
Comment 4 Lapo Calamandrei 2015-09-17 17:31:54 UTC
Nothing changed there themewise, I've seen a similarly weird issue with gdtaggedentry, is that the widget used there?
Comment 5 Lapo Calamandrei 2015-09-17 17:35:56 UTC
Bastien, I'm pretty sure it isn't a theme bug, I was a libgd issue which I think as been fixed. That needs love themewise whatever though, but it should be dealt with with app shipped css.
Comment 6 Bastien Nocera 2015-09-17 18:07:43 UTC
(In reply to Lapo Calamandrei from comment #5)
> Bastien, I'm pretty sure it isn't a theme bug, I was a libgd issue which I
> think as been fixed. That needs love themewise whatever though, but it
> should be dealt with with app shipped css.

The libgd submodule was updated at the end of August, for both 3.16 and 3.17, so the same code runs in both cases. It works against GTK+ 3.16, but not against GTK+ 3.17, so the problem has to be either in the theme code, or GTK+ itself.
Comment 7 Benjamin Otte (Company) 2015-09-17 18:58:57 UTC
Created attachment 311580 [details] [review]
GdTaggedEntry: Add a missing gtk_style_context_restore()

This could cause nasty side effects messing up the whole rendering of
the GdTaggedEntry.
Comment 8 Cosimo Cecchi 2015-09-17 19:25:30 UTC
Review of attachment 311580 [details] [review]:

Nice catch! Looks good.