After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 755134 - dashdemux: Properly handle relative and non-HTTP URIs for the headers/indices
dashdemux: Properly handle relative and non-HTTP URIs for the headers/indices
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.6.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-16 21:40 UTC by Sebastian Dröge (slomo)
Modified: 2015-10-02 08:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dashdemux: Properly handle relative and non-HTTP URIs for the headers/indices (1.75 KB, patch)
2015-09-16 21:40 UTC, Sebastian Dröge (slomo) 		committed Details | Review
uri: Add test for correct absolute URI handling in gst_uri_from_string_with_base() (1.53 KB, patch)
2015-09-16 21:41 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2015-09-16 21:40:02 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2015-09-16 21:40:08 UTC 
Created attachment 311509 [details] [review]
dashdemux: Properly handle relative and non-HTTP URIs for the headers/indices

gst_uri_join_strings() will return the second parameter if it is an absolute
URI. No need to do a (wrong) check if the URI is absolute or not beforehand.
Comment 2 Sebastian Dröge (slomo) 2015-09-16 21:41:51 UTC 
Created attachment 311510 [details] [review]
uri: Add test for correct absolute URI handling in gst_uri_from_string_with_base()

If the second parameter is an absolute URI, the base should have no effect and
the second parameter should be returned again.
Comment 3 Sebastian Dröge (slomo) 2015-09-17 09:15:23 UTC 
This actually has no effect at all, but simplifies the code a bit ;)
Comment 4 Sebastian Dröge (slomo) 2015-09-25 22:31:52 UTC 
commit 7c9525830ef628bc31a2c50c0614c820a9e9875a
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Sep 16 23:38:24 2015 +0200

    dashdemux: Properly handle relative and non-HTTP URIs for the headers/indices
    
    gst_uri_join_strings() will return the second parameter if it is an absolute
    URI. No need to do a (wrong) check if the URI is absolute or not beforehand.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755134