GNOME Bugzilla – Bug 755114
Use a Common Autotools Module to Create The Visual Studio Projects
Last modified: 2015-09-17 01:49:37 UTC
Hi, I do understand that currently ATK uses Python to generate the full Visual Studio 2008/2010 projects from the templates, which I did before, but it has a shortcoming: i.e. it is not able to support 'make -jN dist'. So, I think it is probably better to go back to using autotools for doing the job, but in a way that is different from before, so that we don't add up much clutter in the autotools file, and we can remove the need for Python for 'make dist'. This new approach is the one that is now used in GLib, Pango and GTK+-3.x. With blessings, thank you!
Created attachment 311462 [details] [review] Build: Add common autotools module for generating the full Visual Studio projects from the templates Hi, This is essentially the same autotools module used in GLib, Pango and GTK+, that is used to generate the Visual Studio projects. I will post another patch in a bit to convert the atk/Makefile.am to use this module.
Created attachment 311464 [details] [review] Build: Clean Up Visual Studio Projects Generation Hi, This is the patch that converts atk/Makefile.am to use the autotools module in attachment 311462 [details] [review] to generate the full Visual Studio 2008/2010 projects from their templates (note: the 2012, 2013 and 2015 projects are generated from another script from the Visual Studio 2010 ones), and to remove the Python tools that were used to generate the Visual Studio projects.
Created attachment 311465 [details] [review] configure.ac: Remove Check for Python Hi, Since we are no longer using Python to generate the full Visual Studio projects, we can just drop the check for Python in configure.ac. With blessings, thank you!
Review of attachment 311462 [details] [review]: Fix the email and as pointed out on the previous review, a comment on the file pointing to the main module would be good.
Review of attachment 311464 [details] [review]: Go ahead.
Review of attachment 311465 [details] [review]: Looks good.
Hi Nacho, Thanks for the review and the comments, I have pushed the patches as follows: -Attachment 311462 [details]: (With updates suggested): acee891 -Attachment 311464 [details]: 9ae6ef5 -Attachment 311465 [details]: 510fc6a With blessings, thank you!