GNOME Bugzilla – Bug 755064
Nothing happens when I click on an unreachable document on recent view
Last modified: 2015-10-18 16:11:38 UTC
An unreachable document which I have previously opened through sftp shows up at the Recent View. When I click on the icon, nothing happens. I think users should be notified that "the specific location does not exists or is unreachable", or the document should be in recent view in the first place. I can work on a patch for it, but I wonder which approach should I implement (notification or hide document from recent view).
Local documents that do not exists any more are not shown in the recent view. Although, Carlos was reluctant to do that. Now I found why: Bug 674188 https://git.gnome.org/browse/evince/commit/?id=df46a24a7d52b217182f01be995721255941128e The problem is that gtk_recent_info_exists() does a stat on the file to check whether it exists, and thta causes a problem on locally mounted remote or external file systems. So, I think it's better to have unexitent files in the recent menu (which is unlikley) than slowing down evince startup. That was before the recent view window, which reintroduces the issue (I just noticed). IIRC, we did not check for remote ones. Checking if a remote document exist is an expensive operation. It could be done asynchronously (If worth the effort). FWIW, the discussion of the new Recent View window is in Bug 633501
It turns out that we already show such error messages for documents we can't reach, BUT this messages aren't shown on the Recent View view. So in my use-case, when I click on the unreachable document, the message is correctly set but it does not get shown. I managed to show it by re-parenting ev_window->priv->view_box.
Created attachment 311532 [details] [review] Show message area messages on Recent view
Created attachment 311533 [details] screenshot
Comment on attachment 311532 [details] [review] Show message area messages on Recent view nevermind. It introduces a bug on preview mode.
Created attachment 311620 [details] [review] show message area messages on recent view
Carlos?
Comment on attachment 311620 [details] [review] show message area messages on recent view Thanks
Review of attachment 311620 [details] [review]: Pushed in master