After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754996 - [review] [platform] refresh linked-links when parent disappears and save REFRESH_LINK [th/platform-refresh-link-bgo754996]
[review] [platform] refresh linked-links when parent disappears and save REFR...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2015-09-14 13:36 UTC by Thomas Haller
Modified: 2015-09-18 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2015-09-14 13:36:25 UTC 
Please review
Comment 1 Thomas Haller 2015-09-14 13:36:59 UTC 
th/platform-refresh-link-bgo754996
Comment 2 Thomas Haller 2015-09-14 13:41:17 UTC 
commit 79a7570859e9851987e4a143ef27cc7f2115b5e8
Author: Thomas Haller <thaller@redhat.com>
Date:   Mon Sep 14 15:27:36 2015

    platform: cancel delayed action REFRESH_LINK when receiving an update
    
    When we receive an update for a link, cancel the scheduled
    REFRESH_LINK delayed-action. At the point when we scheduled
    refrehing the link, we only cared about receiving a notification
    that was newer then the current state, i.e. to resync with the
    actual netlink state.
    
    We don't necessarily require to sent a new link-request. This
    extra work can be saved if we already receive a new update for
    the link.

 src/platform/nm-linux-platform.c | 36 ++++++++++++++++++++++++++++++------
 1 file changed, 30 insertions(+), 6 deletions(-)




commit 5d05b82fca77fca14fd1cd79a12a64eee836b710
Author: Thomas Haller <thaller@redhat.com>
Date:   Mon Sep 14 15:05:00 2015

    platform: refresh links when parent gets removed
    
    When moving a link to another netns, it gets removed from
    NMPlatform's view. Ensure that we reload all linked interfaces
    which now might have an invisible parent.

 src/platform/nm-linux-platform.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
Comment 3 Beniamino Galvani 2015-09-18 09:22:08 UTC 
LGTM.