GNOME Bugzilla – Bug 754995
gtkplacessidebar: protect for checking a null event
Last modified: 2015-09-15 06:52:34 UTC
Downstream bug https://bugzilla.redhat.com/show_bug.cgi?id=1207187
Created attachment 311281 [details] [review] gtkplacessidebar: protect for checking a null event We are using the current gtk event position to check if the user clicked in the eject button of a row. However, we are calling this in row-activated signal, which can happens when the gtk+ mainloop already removed the "current" event, and therefore we were trying to access a null event position which crashes the sidebar. To fix it check if we have as current event, and if not, we will not check for the position. But it's better than crashing, and shouldn't happen too much.
Review of attachment 311281 [details] [review]: ok
This only applies to 3.14, I guess ? Please push it whereever it applies.
Yes to 3.14. Thanks for review. Attachment 311281 [details] pushed as 2db7e3e - gtkplacessidebar: protect for checking a null event