After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754937 - Remove wayland specific clutter backend setting
Remove wayland specific clutter backend setting
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-12 22:27 UTC by Lionel Landwerlin
Modified: 2015-09-15 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
totem: remove wayland specific clutter backend setting (1.51 KB, patch)
2015-09-12 22:27 UTC, Lionel Landwerlin 		needs-work Details | Review
Revert "main: Bring back video inside the window under Wayland" (1.55 KB, patch)
2015-09-15 11:38 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2015-09-12 22:27:11 UTC 
Some progress has been made to support Wayland properly in the
Clutter/GDK backend. It seems to work fine now, so let's remove the
wayland specific setup in Totem.
Comment 1 Lionel Landwerlin 2015-09-12 22:27:18 UTC 
Created attachment 311219 [details] [review]
totem: remove wayland specific clutter backend setting

Some progress has been made to support Wayland properly in the
Clutter/GDK backend. It seems to work fine now, so let's remove the
wayland specific setup in Totem.
Comment 2 Bastien Nocera 2015-09-14 13:22:04 UTC 
Review of attachment 311219 [details] [review]:

Could you please do this as a revert of 6051dd76ac5e1738e00cbb677aeadea32e3df3be instead?

We should be able to release this without asking for a freeze break, as totem 3.18 == 3.16.
Comment 3 Lionel Landwerlin 2015-09-14 13:52:44 UTC 
I wouldn't recommend to land that in 3.16, as without all the work in Cogl/Clutter/Clutter-Gtk (those patches are on the master branch of Clutter/Clutter-Gtk), it won't work correctly.
Comment 4 Bastien Nocera 2015-09-14 14:13:56 UTC 
(In reply to Lionel Landwerlin from comment #3)
> I wouldn't recommend to land that in 3.16, as without all the work in
> Cogl/Clutter/Clutter-Gtk (those patches are on the master branch of
> Clutter/Clutter-Gtk), it won't work correctly.

But the clutter in 3.16 didn't use GDK as the default backend for Wayland, so wouldn't have had this problem in the first place.
Comment 5 Lionel Landwerlin 2015-09-14 14:14:58 UTC 
Oh right, cool, will do.
Comment 6 Lionel Landwerlin 2015-09-15 11:38:12 UTC 
Created attachment 311353 [details] [review]
Revert "main: Bring back video inside the window under Wayland"

This reverts commit 6051dd76ac5e1738e00cbb677aeadea32e3df3be.

Now that Clutter/Clutter-Gtk work correctly with the GDK backend of Clutter,
we can revert this.
Comment 7 Lionel Landwerlin 2015-09-15 11:42:19 UTC 
Review of attachment 311353 [details] [review]:

Pushed to master.