After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754902 - cerbero: Should consider sysroot when building PKG_CONFIG env
cerbero: Should consider sysroot when building PKG_CONFIG env
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-11 19:16 UTC by Nicolas Dufresne (ndufresne)
Modified: 2015-10-02 21:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Include sysroot value when building pkg-config env (1.87 KB, patch)
2015-09-11 19:21 UTC, Nicolas Dufresne (ndufresne) 		none Details | Review
Include sysroot value when building pkg-config env (1.80 KB, patch)
2015-09-11 19:43 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2015-09-11 19:16:39 UTC 
I was trying to cross compile with cerbero but hit a issue with repository that do require external (aka external to cerbero prefix) dependencies. The issue is that we ignore "sysroot" configuration when building the PKG_CONFIG env. The following patch is a suggested fix for this issue. I'm open to comment of course.
Comment 1 Nicolas Dufresne (ndufresne) 2015-09-11 19:21:23 UTC 
Created attachment 311175 [details] [review]
Include sysroot value when building pkg-config env

The problem was that when cross-compiling and in need to link against
system library, we would pick .pc files from the host rather then from
the sysroot.

This patch simply prepent the sysroot configuration (if set) so .pc file
is now picked from the sysroot when needed (and allowed).
Comment 2 Nicolas Dufresne (ndufresne) 2015-09-11 19:43:36 UTC 
Created attachment 311176 [details] [review]
Include sysroot value when building pkg-config env

The problem was that when cross-compiling and in need to link against
system library, we would pick .pc files from the host rather then from
the sysroot.

This patch simply prepent the sysroot configuration (if set) so .pc file
is now picked from the sysroot when needed (and allowed).
Comment 3 Nicolas Dufresne (ndufresne) 2015-09-11 19:44:23 UTC 
I just removed the left over debug trace.
Comment 4 Nicolas Dufresne (ndufresne) 2015-10-02 21:35:40 UTC 
Attachment 311176 [details] pushed as 6e30bd3 - Include sysroot value when building pkg-config env