After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754878 - API inconsistency issue
API inconsistency issue
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
2.30.x
Other Windows
: Normal major
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-11 11:55 UTC by Sarita Rawat
Modified: 2016-12-19 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
NULL checking added in file gdk-pixbuf-scale.c & function header modified for gdk-pixbuf-util.c (2.27 KB, text/plain)
2015-09-11 11:55 UTC, Sarita Rawat
  Details
PLease ignore the previous attachment (1.36 KB, patch)
2015-09-11 12:02 UTC, Sarita Rawat
none Details | Review

Description Sarita Rawat 2015-09-11 11:55:35 UTC
Created attachment 311138 [details]
NULL checking added in file gdk-pixbuf-scale.c & function header modified for gdk-pixbuf-util.c

In gdk-pixbuf-scale.c file, gdk_pixbuf_rotate_simple() & gdk_pixbuf_flip()
functions are public where user pass the GdkPixbuf *src while calling the functions.
Inside both functions src pointer is derefrenced without being checked for NULL pointer.
Since both are public APIs NULL check should be mandatory.

For gdk-pixbuf-util.c file, function header of gdk_pixbuf_apply_embedded_orientation
is changed since this function can also return NULL value.

Note: Please find the patch for the above mentioned changes in the attachment
Comment 1 Sarita Rawat 2015-09-11 12:02:45 UTC
Created attachment 311139 [details] [review]
PLease ignore the previous attachment

PLease ignore the previous attachment.
Comment 2 Bastien Nocera 2016-12-19 18:11:30 UTC
Please provide git-formatted patches in the future.