After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754757 - gl/eagl: Don't make context uncurrent just to make it current again in the next line
gl/eagl: Don't make context uncurrent just to make it current again in the ne...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-09 06:28 UTC by Sebastian Dröge (slomo)
Modified: 2015-09-09 07:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gl/eagl: Don't make context uncurrent just to make it current again in the next line (1.23 KB, patch)
2015-09-09 06:28 UTC, Sebastian Dröge (slomo)
committed Details | Review
gl/eagl: Also unbind renderbuffer after setting up framebuffer (918 bytes, patch)
2015-09-09 06:33 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2015-09-09 06:28:41 UTC
See commit message, shouldn't have any effect other than not doing unnecessary
things. It's leftover from cleaning up the framebuffer setup.
Comment 1 Sebastian Dröge (slomo) 2015-09-09 06:28:47 UTC
Created attachment 310949 [details] [review]
gl/eagl: Don't make context uncurrent just to make it current again in the next line

Also binding the framebuffer again is unnecessary then as it was just bound a
few lines before while the context was current.
Comment 2 Sebastian Dröge (slomo) 2015-09-09 06:33:32 UTC
Created attachment 310953 [details] [review]
gl/eagl: Also unbind renderbuffer after setting up framebuffer
Comment 3 Sebastian Dröge (slomo) 2015-09-09 07:11:58 UTC
commit bab55828ae7425f1a62d1f8948e90c5a4c2bceb9
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Sep 9 09:33:01 2015 +0300

    gl/eagl: Also unbind renderbuffer after setting up framebuffer
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754757

commit c97144b23b843a3fd9d2a2bc15b18d2dcbb968f6
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Sep 9 09:27:17 2015 +0300

    gl/eagl: Don't make context uncurrent just to make it current again in the next line
    
    Also binding the framebuffer again is unnecessary then as it was just bound a
    few lines before while the context was current.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754757