After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754703 - High CPU load when displaying ringchart in backdrop mode
High CPU load when displaying ringchart in backdrop mode
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-07 21:19 UTC by Sebastian Keller
Modified: 2015-09-10 11:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Ringchart: always use the correct state when getting colors (3.57 KB, patch)
2015-09-07 21:19 UTC, Sebastian Keller 		committed Details | Review

Description Sebastian Keller 2015-09-07 21:19:59 UTC 
Created attachment 310864 [details] [review]
Ringchart: always use the correct state when getting colors

When the ringchart is shown, change focus to a different window and watch the CPU usage of baobab go up. Once the window gets focused again the CPU usage is back to normal.

This problem is due to the ringchart triggering an invalidation + redraw from inside its draw function if the window is in the backdrop state resulting in a redrawing loop. I'm attaching a patch to fix this.

(I've only noticed this issue in combination with gtk 3.17.x, but earlier versions might be affected as well.)
Comment 1 Stefano Facchini 2015-09-10 11:35:17 UTC 
thanks!

Attachment 310864 [details] pushed as 5380d41 - Ringchart: always use the correct state when getting colors