GNOME Bugzilla – Bug 754694
Disable just gdk-pixbuf test when unavailable
Last modified: 2019-03-20 10:40:19 UTC
When compiling gom on a system without gdk-pixbuf I noticed that configure should have automatically disabled the testsuite but didn't, which resulted in a compile-time error due to a missing gdk-pixbuf header. This patch introduces ENABLE_GLIB_TEST in tests/Makefile.include, fixing the aforementioned issue.
Created attachment 310840 [details] [review] patch
Review of attachment 310840 [details] [review]: ::: tests/Makefile.include @@ +1,1 @@ +if ENABLE_GLIB_TEST No, we should run all the tests but the one that requires gdk-pixbuf, and not none of them.
Created attachment 310912 [details] [review] patch fair enough I created a new patch that puts the automake conditional around the lines involving test-gom-transform, which appears to be the only test relying on gdk-pixbuf.
Actually, your first patch was right. We should have a separate conditional for whether gdk-pixbuf is available or not.
Comment on attachment 310840 [details] [review] patch commit 51eeff0ce27e2762c889fd106c4cd1bfb39e9fff Author: Tom Schoonjans <Tom.Schoonjans@bam.de> Date: Mon Sep 7 18:03:48 2015 +0200 build: Don't build tests when tests are disabled --disable-glibtest should disable all the tests. As we do the equivalent of passing that flag when gdk-pixbuf is not available, make sure not to try and build tests when gdk-pixbuf is unavailable. In the future, we should just disable the gdk-pixbuf requiring test when it's not available, instead of disabling all the tests. https://bugzilla.gnome.org/show_bug.cgi?id=754694
Retitling and leaving open.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gom/issues/18.