GNOME Bugzilla – Bug 754686
adaptivedemux: statistics message name macro is unprefixed
Last modified: 2015-09-17 16:59:12 UTC
The STATISTICS_MESSAGE_NAME macro should be GST_-prefixed because it's exposed in a public header.
Created attachment 310829 [details] [review] adaptivedemux: prefix the statistics message name macro
Comment on attachment 310829 [details] [review] adaptivedemux: prefix the statistics message name macro Thanks, but I think it should be prefixed fully then, i.e. GST_ADAPTIVE_DEMUX_STATISTICS_MESSAGE_NAME, even if it's longer.
Created attachment 311260 [details] [review] adaptivedemux: prefix the statistics message name macro
Created attachment 311261 [details] [review] adaptivedemux: prefix the statistics message name macro
Thanks. I kept the old define around for now with deprecation guards, and added a gtk-doc blurb with since marker for the new one. commit 261d8daca06f4852887e519b7339ca670dc42a79 Author: Philippe Normand <philn@igalia.com> Date: Mon Sep 7 16:57:05 2015 +0200 adaptivedemux: prefix the statistics message name macro Keep old define around for now. https://bugzilla.gnome.org/show_bug.cgi?id=754686
As Sebastian pointed out on IRC, the define was only added in this cycle, so we might just as well remove it fully. Sorry for the noise! commit d331f01e03ecef2f4e0d18c19e5ebc1d73d59bcd Author: Tim-Philipp Müller <tim@centricular.com> Date: Thu Sep 17 17:54:36 2015 +0100 adaptivedemux: remove unprefix STATISTICS_MESSAGE_NAME after all It was only added during 1.5.x so we might just as well remove it immediately. https://bugzilla.gnome.org/show_bug.cgi?id=754686