After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754681 - Plug a memory leak when checking installed schemas
Plug a memory leak when checking installed schemas
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-07 13:51 UTC by Rui Matos
Modified: 2015-09-07 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Plug a memory leak when checking installed schemas (1.91 KB, patch)
2015-09-07 13:51 UTC, Rui Matos 		committed Details | Review
daemon: Plug a memory leak when checking installed schemas (2.21 KB, patch)
2015-09-07 13:51 UTC, Rui Matos 		committed Details | Review
common: Plug a memory leak when checking installed schemas (1.81 KB, patch)
2015-09-07 13:51 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2015-09-07 13:51:13 UTC 
Also switched to using g_strv_contains() since that's now a thing in
glib.
Comment 1 Rui Matos 2015-09-07 13:51:17 UTC 
Created attachment 310822 [details] [review]
keyboard: Plug a memory leak when checking installed schemas

g_settings_schema_source_list_schemas() returns allocated string
arrays that must be freed.
Comment 2 Rui Matos 2015-09-07 13:51:22 UTC 
Created attachment 310823 [details] [review]
daemon: Plug a memory leak when checking installed schemas

g_settings_schema_source_list_schemas() returns allocated string
arrays that must be freed.
Comment 3 Rui Matos 2015-09-07 13:51:27 UTC 
Created attachment 310824 [details] [review]
common: Plug a memory leak when checking installed schemas

g_settings_schema_source_list_schemas() returns allocated string
arrays that must be freed.
Comment 4 Bastien Nocera 2015-09-07 14:34:27 UTC 
Review of attachment 310822 [details] [review]:

Sure.
Comment 5 Bastien Nocera 2015-09-07 14:34:44 UTC 
Review of attachment 310823 [details] [review]:

Yes.
Comment 6 Bastien Nocera 2015-09-07 14:35:10 UTC 
Review of attachment 310824 [details] [review]:

Sure.
Comment 7 Rui Matos 2015-09-07 14:43:23 UTC 
Attachment 310822 [details] pushed as 7eabee7 - keyboard: Plug a memory leak when checking installed schemas
Attachment 310823 [details] pushed as 9982541 - daemon: Plug a memory leak when checking installed schemas
Attachment 310824 [details] pushed as 0c5ef3d - common: Plug a memory leak when checking installed schemas