After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754670 - Mac OS X compilation fix
Mac OS X compilation fix
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
3.16.x
Other Mac OS
: Normal normal
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-09-07 11:23 UTC by Tom Schoonjans
Modified: 2015-09-07 17:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (869 bytes, patch)
2015-09-07 11:23 UTC, Tom Schoonjans 		needs-work Details | Review
build: Fix compilation under MacOS X (956 bytes, patch)
2015-09-07 12:49 UTC, Bastien Nocera 		committed Details | Review

Description Tom Schoonjans 2015-09-07 11:23:16 UTC 
The following fix is necessary to ensure compilation on Mac OS X Yosemite
Comment 1 Tom Schoonjans 2015-09-07 11:23:42 UTC 
Created attachment 310800 [details] [review]
patch
Comment 2 Zeeshan Ali 2015-09-07 12:43:13 UTC 
Review of attachment 310800 [details] [review]:

Looks good to me. I'd complain about shortlog summarizing benefit rather than change but hadess doesn't like that so i'll merge it.
Comment 3 Bastien Nocera 2015-09-07 12:47:44 UTC 
Review of attachment 310800 [details] [review]:

The commit log is incorrect though, as it doesn't explain why it fixes things.
Comment 4 Bastien Nocera 2015-09-07 12:49:47 UTC 
Created attachment 310811 [details] [review]
build: Fix compilation under MacOS X

The MacOS X linker doesn't seem to like us exporting undefined symbols.
Seeing as _geocode_parse_resolve_json doesn't exist any more, don't
export it and fix MacOS X linking.
Comment 5 Tom Schoonjans 2015-09-07 12:55:03 UTC 
Thanks for merging in the patch!
Comment 6 Bastien Nocera 2015-09-07 16:05:00 UTC 
I didn't merge anything yet. It needs reviewing.
Comment 7 Jonas Danielsson 2015-09-07 17:35:23 UTC 
Review of attachment 310811 [details] [review]:

Looks fine to me!

Thanks!
Comment 8 Jonas Danielsson 2015-09-07 17:37:15 UTC 
Attachment 310811 [details] pushed as 27345fc - build: Fix compilation under MacOS X