After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754668 - mpdparser: fix incorrect start value scaling
mpdparser: fix incorrect start value scaling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-07 11:13 UTC by Vincent Penquerc'h
Modified: 2015-09-07 11:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mpdparser: fix incorrect start value scaling (1.39 KB, patch)
2015-09-07 11:13 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2015-09-07 11:13:29 UTC 
Created attachment 310798 [details] [review]
mpdparser: fix incorrect start value scaling

This GstStreamPeriod start value is expressed in nanoseconds,
    and the glib time addition function expects microseconds.
    There seems to have been a confusion with GstPeriodNode's start
    field, which is expressed in milliseconds.
    
    Additionally, add a warning if the timestamp modification did
    not succeed, and NULL was returned.
Comment 1 Vincent Penquerc'h 2015-09-07 11:46:57 UTC 
You marked this as "commit now", can you confirm it's really now (as opposed to after the freeze), as the 1.6 release doesn't seem to have happened yet (based on git tag) ?
Comment 2 Sebastian Dröge (slomo) 2015-09-07 11:50:58 UTC 
Correct :) There's accepted-commit-after-freeze for the other case
Comment 3 Vincent Penquerc'h 2015-09-07 11:55:03 UTC 
Thanks, pushed.