After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754654 - Fixes for staticmethod definitions
Fixes for staticmethod definitions
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal minor
: 3.16
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-07 03:42 UTC by Peter Shinners
Modified: 2015-09-14 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
staticmethod definitions (3.32 KB, patch)
2015-09-07 03:42 UTC, Peter Shinners 		none Details | Review
git format-patch of the previous (3.56 KB, patch)
2015-09-07 16:12 UTC, Peter Shinners 		none Details | Review

Description Peter Shinners 2015-09-07 03:42:12 UTC 
Created attachment 310774 [details] [review]
staticmethod definitions

Several classmethods and methods switched to staticmethod. This is a minor Python cleanup. No functionality or logic changes.
Comment 1 Vadim Rutkovsky 2015-09-07 11:39:20 UTC 
(In reply to Peter Shinners from comment #0)
> Created attachment 310774 [details] [review] [review]
> staticmethod definitions

LGTM at a glance, however patch format is ugly. Please use git format-patch, see https://wiki.gnome.org/Git/WorkingWithPatches#How_to_make_a_patch
Comment 2 Peter Shinners 2015-09-07 16:08:41 UTC 
New patch incoming...
Comment 3 Peter Shinners 2015-09-07 16:12:38 UTC 
Created attachment 310842 [details] [review]
git format-patch of the previous
Comment 4 Vadim Rutkovsky 2015-09-14 08:51:55 UTC 
Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=50bac83