After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754630 - libs: "ll" printf modifier isn't available on MinGW
libs: "ll" printf modifier isn't available on MinGW
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.5.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-09-06 09:37 UTC by Kouhei Sutou
Modified: 2015-09-06 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix this problem (1.05 KB, patch)
2015-09-06 09:37 UTC, Kouhei Sutou 		committed Details | Review

Description Kouhei Sutou 2015-09-06 09:37:24 UTC 
Created attachment 310742 [details] [review]
Fix this problem

gst-libs/gst/video/video-dither.c uses "llx" for printing unsigned long long int value. It causes a build error on MinGW because "llx" isn't portable.

We can use G_GINT64_MODIFIER instead of "ll" for 64bit int value.
Comment 1 Sebastian Dröge (slomo) 2015-09-06 15:32:43 UTC 
Also fixed this before pushing your commit:
video-dither.c: In function 'gst_video_dither_new':
video-dither.c:416:14: warning: format '%lx' expects argument of type 'long unsigned int', but argument 8 has type 'long long unsigned int' [-Wformat=]
   GST_DEBUG ("mask64 %08" G_GINT64_MODIFIER "x",
              ^


commit 3e41e784bedd56c796834aabf022e8a28f79f691
Author: Kouhei Sutou <kou@clear-code.com>
Date:   Sun Sep 6 18:17:15 2015 +0900

    libs: Fix build error on MinGW where "%ll" is not available
    
    "ll" isn't available on MinGW. We can use G_GINT64_MODIFIER for portable
    64bit size data modifier.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754630