After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 754617 - Gnucash should use PKG_PROG_PKG_CONFIG
Gnucash should use PKG_PROG_PKG_CONFIG
Status: RESOLVED NOTABUG
Product: GnuCash
Classification: Other
Component: Build system
2.6.7
Other Linux
: Normal normal
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2015-09-05 20:15 UTC by thomas anderson
Modified: 2018-06-29 23:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use PKG_PROG_PKG_CONFIG (870 bytes, patch)
2015-09-05 20:15 UTC, thomas anderson 		rejected Details | Review

Description thomas anderson 2015-09-05 20:15:55 UTC 
Created attachment 310722 [details] [review]
Use PKG_PROG_PKG_CONFIG

The recommended practice is to use the PKG_PROG_PKG_CONFIG macro for checking the presence of pkg-config. This is for portability, since distributions may have the pkg-config script installed as ${host}-pkg-config on a multiarch system.

A patch is attached.
Comment 1 John Ralls 2015-09-13 01:03:05 UTC 
We already do, configure.ac line 110 (maint branch).

That, combined with the long-ago demise of Ximian makes the segment of your patch redundant so I've just deleted the whole thing.
Comment 2 thomas anderson 2015-09-13 01:26:27 UTC 
I see that, thanks. Is this change already pushed to github? I don't see it on github's maint or  master branch yet.
Comment 3 John Ralls 2015-09-13 02:38:37 UTC 
It is now. I got summoned to dinner in the middle of pulling-before-pushing.
Comment 4 John Ralls 2018-06-29 23:42:54 UTC 
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=754617. Please update any external references or bookmarks.